Re: [Musicpd-dev-team] [PATCH] Add tag support to DSD decoders

2012-10-06 Thread Max Kellermann
On 2012/10/05 09:10, Jurgen Kramer gtmkra...@xs4all.nl wrote: If added these checks to dsdlib_tag_id3(): + /* Prevent broken files causing problems */ + if (is-offset = is-size) + return; + + count = is-size - is-offset; + /* ID3 tag cannot be larger then complete file */ + if

Re: [Musicpd-dev-team] [PATCH] Add tag support to DSD decoders

2012-10-06 Thread Jurgen Kramer
On Sat, 2012-10-06 at 17:27 +0200, Max Kellermann wrote: On 2012/10/05 09:10, Jurgen Kramer gtmkra...@xs4all.nl wrote: If added these checks to dsdlib_tag_id3(): + /* Prevent broken files causing problems */ + if (is-offset = is-size) + return; + + count = is-size - is-offset; +

Re: [Musicpd-dev-team] [PATCH] Add tag support to DSD decoders

2012-10-05 Thread Jurgen Kramer
On Thu, 2012-10-04 at 23:02 +0200, Max Kellermann wrote: On 2012/10/04 18:35, Jurgen Kramer gtmkra...@xs4all.nl wrote: I went through the e-mails, I do not recall you having problems with dsdiff_handle_native_tag(). You made the same mistake twice. Maybe I didn't point you to the second

Re: [Musicpd-dev-team] [PATCH] Add tag support to DSD decoders

2012-10-04 Thread Max Kellermann
On 2012/09/28 09:29, Jurgen Kramer gtmkra...@xs4all.nl wrote: Patch to enable tag support for DSDIFF and DSF DSD decoders. Sent to Max on 19/09. Post here for completeness. Fails to build: src/decoder/dsdlib.c:130:9: error: use of undeclared identifier 'taggoffset'; did you mean 'tagoffset'?

Re: [Musicpd-dev-team] [PATCH] Add tag support to DSD decoders

2012-10-04 Thread Jurgen Kramer
On Thu, 2012-10-04 at 09:59 +0200, Max Kellermann wrote: On 2012/09/28 09:29, Jurgen Kramer gtmkra...@xs4all.nl wrote: Patch to enable tag support for DSDIFF and DSF DSD decoders. Sent to Max on 19/09. Post here for completeness. Fails to build: src/decoder/dsdlib.c:130:9: error: use

Re: [Musicpd-dev-team] [PATCH] Add tag support to DSD decoders

2012-10-04 Thread Max Kellermann
On 2012/10/04 18:13, Jurgen Kramer gtmkra...@xs4all.nl wrote: Fixed. I've created a new, clean, commit. Patch to enable tag support for DSDIFF and DSF DSD decoders. You did not fix the stack overflow bug, did you? I still see it in dsdiff_handle_native_tag().

Re: [Musicpd-dev-team] [PATCH] Add tag support to DSD decoders

2012-10-04 Thread Max Kellermann
On 2012/10/04 18:35, Jurgen Kramer gtmkra...@xs4all.nl wrote: I went through the e-mails, I do not recall you having problems with dsdiff_handle_native_tag(). You made the same mistake twice. Maybe I didn't point you to the second instance of the same bug. We discussed dsdlib_tagid3() from

[Musicpd-dev-team] [PATCH] Add tag support to DSD decoders

2012-09-28 Thread Jurgen Kramer
Patch to enable tag support for DSDIFF and DSF DSD decoders. Sent to Max on 19/09. Post here for completeness. http://git.musicpd.org/cgit/gtmkramer/mpd.git/commit/?id=9488b05134cf8ce0d595ffa2186bde22476b2afd Jurgen

Re: [Musicpd-dev-team] [PATCH] Add tag support to DSD decoders - v6

2012-09-19 Thread Jurgen Kramer
On Mon, 2012-09-03 at 23:09 +0200, Max Kellermann wrote: On 2012/08/21 20:01, Jurgen Kramer gtmkra...@xs4all.nl wrote: Can you use dsdlib_tag_id3() for a DoS attack? This looks like it could easily cause a stack overflow: + count = is-size - is-offset; + id3_byte_t

Re: [Musicpd-dev-team] [PATCH] Add tag support to DSD decoders - v6

2012-09-19 Thread Max Kellermann
On 2012/09/19 14:50, Jurgen Kramer gtmkra...@xs4all.nl wrote: Attached is an old fashioned patch with the updated code against current mpd git. There's no patch description. I cannot make heads or tales from the mess that is my mpd git repo. Everything I try only seems to make it worse.

Re: [Musicpd-dev-team] [PATCH] Add tag support to DSD decoders - v6

2012-09-03 Thread Max Kellermann
On 2012/08/21 20:01, Jurgen Kramer gtmkra...@xs4all.nl wrote: Can you use dsdlib_tag_id3() for a DoS attack? This looks like it could easily cause a stack overflow: + count = is-size - is-offset; + id3_byte_t dsdid3[count]; What is your concern here? The allocation of dsdid3

Re: [Musicpd-dev-team] [PATCH] Add tag support to DSD decoders - v6

2012-08-21 Thread Jurgen Kramer
On Mon, 2012-08-20 at 08:44 +0200, Max Kellermann wrote: On 2012/08/16 18:18, Jurgen Kramer gtmkra...@xs4all.nl wrote: Lots of activity in git. Just a reminder for above commit. Memory leak in dsdlib_tag_id3(). Fixed. Added id3_tag_delete Can you use dsdlib_tag_id3() for a DoS attack?

Re: [Musicpd-dev-team] [PATCH] Add tag support to DSD decoders - v6

2012-08-21 Thread Jonathan Neuschäfer
On Tue, Aug 21, 2012 at 08:01:07PM +0200, Jurgen Kramer wrote: Regarding only submitting the needed patches. What the commit I supplied (http://git.musicpd.org/cgit/gtmkramer/mpd.git/commit/?id=9696eff5f075180e88fca504f2502c4f12aef71b) you get more then needed? (I am still not fully proficient

Re: [Musicpd-dev-team] [PATCH] Add tag support to DSD decoders - v6

2012-08-20 Thread Max Kellermann
On 2012/08/16 18:18, Jurgen Kramer gtmkra...@xs4all.nl wrote: Lots of activity in git. Just a reminder for above commit. Memory leak in dsdlib_tag_id3(). Can you use dsdlib_tag_id3() for a DoS attack? This looks like it could easily cause a stack overflow: + count = is-size - is-offset; +

[Musicpd-dev-team] [PATCH] Add tag support to DSD decoders - v6

2012-08-10 Thread Jurgen Kramer
Updated version of my patch to add tag support to the DSD decoders. Now uses scan_id3_tag() to add id3 tags (the comment in src/tag_id3.c/h for scan_id3_tag() may need smartening up). No more warnings when compiling with id3 support disabled. Removes unneeded code when compiling without id3

Re: [Musicpd-dev-team] [PATCH] Add tag support to DSD decoders

2012-08-09 Thread Jurgen Kramer
On Thu, 2012-08-09 at 18:29 +0200, Max Kellermann wrote: On 2012/08/09 18:04, Jurgen Kramer gtmkra...@xs4all.nl wrote: Excerpt: In file included from src/input/ffmpeg_input_plugin.c:26:0: /usr/include/ffmpeg/libavformat/avformat.h:158:1: error: ???AVMetadata??? is deprecated (declared at

Re: [Musicpd-dev-team] [PATCH] Add tag support to DSD decoders

2012-08-08 Thread Jurgen Kramer
On Tue, 2012-08-07 at 20:02 +0200, Max Kellermann wrote: On 2012/08/03 15:22, Jurgen Kramer gtmkra...@xs4all.nl wrote: Commit: http://git.musicpd.org/cgit/gtmkramer/mpd.git/commit/?id=0156b6b1717bfc3c43fee6a6a6c6249f2abcb753 Repo: http://git.musicpd.org/cgit/gtmkramer/mpd.git/ Fails

Re: [Musicpd-dev-team] [PATCH] Add tag support to DSD decoders

2012-08-08 Thread Max Kellermann
On 2012/08/08 17:48, Jurgen Kramer gtmkra...@xs4all.nl wrote: On Tue, 2012-08-07 at 20:02 +0200, Max Kellermann wrote: On 2012/08/03 15:22, Jurgen Kramer gtmkra...@xs4all.nl wrote: Commit: http://git.musicpd.org/cgit/gtmkramer/mpd.git/commit/?id=0156b6b1717bfc3c43fee6a6a6c6249f2abcb753

Re: [Musicpd-dev-team] [PATCH] Add tag support to DSD decoders

2012-08-07 Thread Max Kellermann
On 2012/08/03 15:22, Jurgen Kramer gtmkra...@xs4all.nl wrote: Commit: http://git.musicpd.org/cgit/gtmkramer/mpd.git/commit/?id=0156b6b1717bfc3c43fee6a6a6c6249f2abcb753 Repo: http://git.musicpd.org/cgit/gtmkramer/mpd.git/ Fails to build when libid3tag is disabled: src/decoder/dsdlib.c:142:

Re: [Musicpd-dev-team] [PATCH] Add tag support to DSD decoders

2012-08-05 Thread Jurgen Kramer
On Fri, 2012-08-03 at 15:22 +0200, Jurgen Kramer wrote: Commit: http://git.musicpd.org/cgit/gtmkramer/mpd.git/commit/?id=0156b6b1717bfc3c43fee6a6a6c6249f2abcb753 Repo: http://git.musicpd.org/cgit/gtmkramer/mpd.git/ My repo is not in sync with master (won't matter for this patch) how do I

[Musicpd-dev-team] [PATCH] Add tag support to DSD decoders

2012-08-03 Thread Jurgen Kramer
Commit: http://git.musicpd.org/cgit/gtmkramer/mpd.git/commit/?id=0156b6b1717bfc3c43fee6a6a6c6249f2abcb753 Repo: http://git.musicpd.org/cgit/gtmkramer/mpd.git/ My repo is not in sync with master (won't matter for this patch) how do I keep in sync? Just do a pull of master and push to my git?