Re: [Musicpd-dev-team] [PATCH] idle command enhancement

2008-11-24 Thread Marc Pavot
I attach a new patch that integrates some fixes and ideas proposed by Qball. This patch replaces the previous one. I have added the support of idle command in Ario ( http://ario-player.sourceforge.net/) and I have found something that looks like a bug in MPD: - When a song is finished, the next

Re: [Musicpd-dev-team] [PATCH] idle command enhancement

2008-11-24 Thread Qball Cow
I noticed this problem with gmpc too. So i can confirm. Q Marc Pavot wrote: I attach a new patch that integrates some fixes and ideas proposed by Qball. This patch replaces the previous one. I have added the support of idle command in Ario ( http://ario-player.sourceforge.net/) and I have

Re: [Musicpd-dev-team] [PATCH] idle command enhancement

2008-11-23 Thread Marc Pavot
Hi, Thanks, I have merged your patch. Please write a patch which adds documentation for that feature to doc/protocol.xml. Done. I also attach a patch to libmpdclient that can be used as a basis for the discussion on 'idle' implementation on client side. Main points about this

Re: [Musicpd-dev-team] [PATCH] idle command enhancement

2008-11-22 Thread Max Kellermann
On 2008/11/21 22:35, Marc Pavot [EMAIL PROTECTED] wrote: Someone proposed that idle 10 would make MPD respond after 10 seconds, disregarding whether an event has really happened, and probably returns with an empty event set. Can you make a separate patch of that? And maybe implement the

Re: [Musicpd-dev-team] [PATCH] idle command enhancement

2008-11-21 Thread Marc Pavot
Hi, - It adds the possibility to choose which notification you want to receive. The idle command can now take no argument (same behavior as before) or several arguments. For example if a client uses command 'idle mixer elapsed', it will only receive notifications when the volume changed

Re: [Musicpd-dev-team] [PATCH] idle command enhancement

2008-11-16 Thread Marc Pavot
Hi, This new patch replaces the previous one. It adds the possibility to send the new value in a notification. For example, if the volume changes to 85, MPD sends 'changed: mixer 85'. Marc 2008/11/16 Marc Pavot [EMAIL PROTECTED] Hi, I propose you a patch that improves different aspects of

Re: [Musicpd-dev-team] [PATCH] idle command enhancement

2008-11-16 Thread Max Kellermann
On 2008/11/16 01:08, Marc Pavot [EMAIL PROTECTED] wrote: I propose you a patch that improves different aspects of idle command: Hi Marc, thanks for the patch, it's a useful contribution to the discussion. I have request on the form you send patches: please don't mix two or more different

[Musicpd-dev-team] [PATCH] idle command enhancement

2008-11-15 Thread Marc Pavot
Hi, I propose you a patch that improves different aspects of idle command: - It adds a new 'elapsed' event to notify clients when the elapsed time has changed (in absolute value in second) - It adds the possibility to choose which notification you want to receive. The idle command can now take no