Max Kellermann <[EMAIL PROTECTED]> wrote: > On 2008/09/06 05:33, Eric Wong <[EMAIL PROTECTED]> wrote: > > I've already merged your tag stuff with "struct mpd_tag" since > > that resembles the old name: "MpdTag" > > I didn't choose that name because I thought it was somewhat redundant, > but it's ok for me. This way, we can still have "struct mpd_tag > *tag". We should apply this scheme to all (public) type names.
I wouldn't prefix "mpd_" blindly, either. It's easiest to identify differences in tokens when scanning code by seeing the first few characters; and by making the prefixes the same that increases the amount the eye/mind has work to distinguish things. Also, I'm more than fine with using 2-character variable names if the abbreviations make sense: struct client *cl; struct input_stream *is; struct audio_format *af; /* may be confusing with audiofile */ struct audio_output *ao; /* may be confusing with libao */ struct decoder_control dc; struct output_buffer ob; Abbreviating "tag" was tough, though, so I went with "struct mpd_tag" -- Eric Wong ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
