Re: [Musicpd-dev-team] Tags in OGG httpd stream

2013-10-19 Thread Max Kellermann
On 2013/10/11 05:12, Ben Boeckel maths...@gmail.com wrote: the tag chunk is dropped because chunk-length is 0 for it. A patch which fixes the issue is attached. Merged, thanks. Sorry for letting you wait for so long.

Re: [Musicpd-dev-team] Tags in OGG httpd stream

2013-10-19 Thread Ben Boeckel
On Sat, Oct 19, 2013 at 15:47:25 +0200, Max Kellermann wrote: On 2013/10/11 05:12, Ben Boeckel maths...@gmail.com wrote: the tag chunk is dropped because chunk-length is 0 for it. A patch which fixes the issue is attached. Merged, thanks. Sorry for letting you wait for so long. Thanks!

Re: [Musicpd-dev-team] Tags in OGG httpd stream

2013-10-10 Thread Ben Boeckel
On Wed, Dec 05, 2012 at 16:51:54 -0500, Ben Boeckel wrote: @@ -524,31 +532,7 @@ decoder_replay_gain(struct decoder *decoder, float return_db = 0; assert(decoder != NULL); - if (replay_gain_info != NULL) { - static unsigned serial; - if (++serial ==

Re: [Musicpd-dev-team] Tags in OGG httpd stream

2013-10-10 Thread Ben Boeckel
On Thu, Oct 10, 2013 at 23:12:27 -0400, Ben Boeckel wrote: So this line here was the issue. This flushes the chunk into the stream with just the tag and no data on it. Combined with this code right before the chunk leaves for the sources: It seems this fix isn't complete actually. It works

Re: [Musicpd-dev-team] Tags in OGG httpd stream

2013-10-10 Thread Ben Boeckel
On Fri, Oct 11, 2013 at 00:14:46 -0400, Ben Boeckel wrote: On Thu, Oct 10, 2013 at 23:12:27 -0400, Ben Boeckel wrote: So this line here was the issue. This flushes the chunk into the stream with just the tag and no data on it. Combined with this code right before the chunk leaves for the