25.09.2010 0:11, Thomas Jansen пишет:
> Hi everyone!
>
> In my recent effort to decimate the bug list present on mantis I
> stumbled across bug #2995 and its duplicate #3007. Bottomline is:
> g_error() internally calls abort() which in turn raises SIGABRT leading
> to a core dump. We currently use g_error in all places where a
> non-recoverable error occurs. This leads to dumping the core when
> trying to kill a non-existing mpd-PID or specifying an unknown command
> line argument which hardly justifies measures as drastic as a core dump.
> In total, there are 68 individual calls to g_error().
Looks like implementation is not as good as it could be.
It will fail to compile in the following situation.
if (something_bad_happened)
MPD_ERROR("We're going to crash");
else
save_to_go();
You will have to omit semicolon before "else".
This case was present in output_all.c
I've fixed mpd_error.h and output_all.c in my repository (dk/mpd.git)
Also, I've replaced g_error usages in main_win32.c
------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
