Re: [Musicpd-dev-team] Remove duplicate optimisation for volume

2013-08-16 Thread Matthias Larisch
Am Thu, 15 Aug 2013 22:57:25 -0400 schrieb andrew cooke and...@acooke.org: Hi, I was just looking through the mpd source and noticed that the optimisations in ReplayGainFilter::FilterPCM duplicate code in pcm_volume. So the following code would be equivalent. Hi, While I agree on the

Re: [Musicpd-dev-team] Remove duplicate optimisation for volume

2013-08-16 Thread Max Kellermann
On 2013/08/16 12:27, Matthias Larisch m...@matthias-larisch.de wrote: While I agree on the second case we save one memcpy on the first case. You got it, and that's the reason we have a similar optimisation in two code locations. The two optimisations are not equivalent and neither can be