Re: [Musicpd-dev-team] UPnP db plugin

2013-12-18 Thread Max Kellermann
On 2013/12/18 10:02, j...@dockes.org wrote: +static const string rootid(0); Using std::string here is useless bloat, isn't it? There's much more of this useless bloat in your code. I do not think that this is useless bloat, except if you consider that std::string is useless bloat

Re: [Musicpd-dev-team] UPnP db plugin

2013-12-18 Thread jf
You know what: you are right. The UPnP plugin is 4000 lines of bloat and your nitpicking about a few hundred lines of commodity code inside it has just saved you from the whole packet. A few months ago, I put up with your flat out lies about the Proxy DB plugin (no denying possible, just see

Re: [Musicpd-dev-team] UPnP db plugin

2013-12-18 Thread Max Kellermann
On 2013/12/18 14:43, j...@dockes.org wrote: Please delete my repository from the musicpd site, Done. I've also deleted your Mantis account, and I'll disable your mailing list subscription. Please do not bother me again after calling me a liar.

Re: [Musicpd-dev-team] UPnP db plugin

2013-12-17 Thread jf
Max Kellermann writes: I see many bug fix commit, which fix bugs introduced earlier by yourself. This is confusing to read, and makes the repository hard to bisect. Please fold those into the commit that introduced the bug. Ok, then, I've squashed everything into one commit, as the

Re: [Musicpd-dev-team] UPnP db plugin

2013-12-17 Thread Max Kellermann
On 2013/12/17 18:08, j...@dockes.org wrote: Max Kellermann writes: I see many bug fix commit, which fix bugs introduced earlier by yourself. This is confusing to read, and makes the repository hard to bisect. Please fold those into the commit that introduced the bug. Ok, then, I've