Re: [PATCH] Avoid falsely uncollapsing threads for old messages

2022-09-14 Thread Kevin J. McCarthy
On Wed, Sep 14, 2022 at 02:53:27PM +0200, Magnus Groß wrote: On Wed, Sep 14, 2022 at 12:23:44PM +0800, Kevin J. McCarthy wrote: For that case, Mutt is uncollapsing every thread, passing in the parent message of each thread. But surely it is not intended to uncollapse every thread, just because

Re: [PATCH] Avoid falsely uncollapsing threads for old messages

2022-09-14 Thread Derek Martin
On Wed, Sep 14, 2022 at 02:53:27PM +0200, Magnus Groß wrote: > The thing is that even according to your definition, mutt is > behaving incorrectly: The outgoing message saved via "record" is > **not** a newly received message. Yes, it is. Which is to say, when you place a message in a mail folder

Re: [PATCH] Avoid falsely uncollapsing threads for old messages

2022-09-14 Thread Magnus Groß
On Wed, Sep 14, 2022 at 12:23:44PM +0800, Kevin J. McCarthy wrote: For that case, Mutt is uncollapsing every thread, passing in the parent message of each thread. But surely it is not intended to uncollapse every thread, just because I accidentally happen to reopen the mailbox because I saved

Re: [PATCH] Avoid falsely uncollapsing threads for old messages

2022-09-13 Thread Kevin J. McCarthy
[Sorry for the delayed reply. My access to a computer has been intermittent the past couple weeks, and may continue to be shaky through September.] On Wed, Sep 07, 2022 at 09:57:47PM +0200, Magnus Groß wrote: The "uncollapse_new" option is meant to uncollapse threads that contain **new** mess

[PATCH] Avoid falsely uncollapsing threads for old messages

2022-09-07 Thread Magnus Groß
The "uncollapse_new" option is meant to uncollapse threads that contain **new** messages (as per man page). In the normal case we don't need to do any checks for uncollapsing in update_index_threaded() because that code path usually only iterates over new messages by design. However for some edge