Message-id parsing change

2020-05-13 Thread Kevin J. McCarthy
On Sun, Apr 19, 2020 at 01:03:06AM +0200, Oswald Buddenhagen wrote: on a tangent, mutt's thread linking features do not work if the message-ids lack the . i presume these might be invalid, but they are rather common nonetheless. someone feels like having a look? This was on my todo list, but

Re: Message-id parsing change

2020-05-14 Thread Oswald Buddenhagen
On Wed, May 13, 2020 at 08:03:02PM -0700, Kevin J. McCarthy wrote: On Sun, Apr 19, 2020 at 01:03:06AM +0200, Oswald Buddenhagen wrote: on a tangent, mutt's thread linking features do not work if the message-ids lack the . i presume these might be invalid, but they are rather common nonetheless.

Re: Message-id parsing change

2020-05-14 Thread Gero Treuner
Hi, On Thu, May 14, 2020 at 11:51:08AM +0200, Oswald Buddenhagen wrote: > On Wed, May 13, 2020 at 08:03:02PM -0700, Kevin J. McCarthy wrote: > > On Sun, Apr 19, 2020 at 01:03:06AM +0200, Oswald Buddenhagen wrote: > > > on a tangent, mutt's thread linking features do not work if the > > > message-i

Re: Message-id parsing change

2020-05-14 Thread Arnt Gulbrandsen
This change will make mutt emit bad References fields in a reply. Is that acceptable? Or should you use the evil IDs only for threading and leave them out when generating new messages? Arnt

Re: Message-id parsing change

2020-05-14 Thread Oswald Buddenhagen
On Thu, May 14, 2020 at 12:41:59PM +0200, Gero Treuner wrote: This notifies about possible problems and transparently shows sender's responsibility. If one of the users then complains at aliexpress I'm fine with it ;-) if you think that being a dick to the mutt user is a constructive way to add

Re: Message-id parsing change

2020-05-14 Thread Gero Treuner
Hi Oswald, On Thu, May 14, 2020 at 02:37:31PM +0200, Oswald Buddenhagen wrote: > On Thu, May 14, 2020 at 12:41:59PM +0200, Gero Treuner wrote: > > This notifies about possible problems and transparently shows sender's > > responsibility. If one of the users then complains at aliexpress I'm > > fin

Re: Message-id parsing change

2020-05-14 Thread Kevin J. McCarthy
On Thu, May 14, 2020 at 11:51:08AM +0200, Oswald Buddenhagen wrote: On Wed, May 13, 2020 at 08:03:02PM -0700, Kevin J. McCarthy wrote: However, in order to reduce the risk of extracting garbage, insist that message-id's outside of angle brackets at least have an '@'. well, guess what, the mess

Re: Message-id parsing change

2020-05-14 Thread Arnt Gulbrandsen
FYI you need an @domain as well. Arnt

Re: Message-id parsing change

2020-05-14 Thread Gero Treuner
Hi, On Thu, May 14, 2020 at 02:45:51PM +, Arnt Gulbrandsen wrote: > FYI you need an @domain as well. Arnt And as it is not fixable, because that would make it match nothing, I second your solution to not use those without "@" for new messages. Gero

Re: Message-id parsing change

2020-05-14 Thread Kevin J. McCarthy
On Thu, May 14, 2020 at 02:45:51PM +, Arnt Gulbrandsen wrote: FYI you need an @domain as well. Arnt I'm aware of that, but the parser was already changed to accomodate message-id's with no '@' or even double '@' back in commit 5a27978a in response to Trac tickets 1116, 1975, and 3090. We

Re: Message-id parsing change

2020-05-14 Thread Oswald Buddenhagen
On Thu, May 14, 2020 at 07:18:24AM -0700, Kevin J. McCarthy wrote: On Thu, May 14, 2020 at 11:51:08AM +0200, Oswald Buddenhagen wrote: i think a reasoanble heuristic would be to just accept anything as long as it's a single string with no whitespace. Well, it's not hard to pull the '@' check o

Re: Message-id parsing change

2020-05-14 Thread Kevin J. McCarthy
On Thu, May 14, 2020 at 06:36:28PM +0200, Oswald Buddenhagen wrote: On Thu, May 14, 2020 at 07:18:24AM -0700, Kevin J. McCarthy wrote: On Thu, May 14, 2020 at 11:51:08AM +0200, Oswald Buddenhagen wrote: i think a reasoanble heuristic would be to just accept anything as long as it's a single str