S/MIME display bug

2002-02-26 Thread Mike Schiraldi
Looks like we've got a display-corruption bug in current CVS -- when a message arrives whose From address doesn't match any in the S/MIME cert (like this message), the screen gets garbled. A warning should absolutely be displayed, but should mutt_any_key_to_continue() be called? A previous

Re: S/MIME display bug

2002-02-26 Thread Oliver Ehli
On Mon, Feb 25, 2002 at 02:24:27PM -0500, Mike Schiraldi wrote: Looks like we've got a display-corruption bug in current CVS -- when a message arrives whose From address doesn't match any in the S/MIME cert (like this message), the screen gets garbled. A warning should absolutely be

Re: S/MIME display bug

2002-02-26 Thread Luke Ross
Hi, On Mon, Feb 25, 2002 at 02:24:27PM -0500, Mike Schiraldi wrote: Looks like we've got a display-corruption bug in current CVS -- when a message arrives whose From address doesn't match any in the S/MIME cert (like this message), the screen gets garbled. A warning should absolutely be

Re: S/MIME display bug

2002-02-26 Thread David Collantes
On Tue, Feb 26, 2002 at 12:20:33PM +0100, Oliver Ehli wrote: A warning should absolutely be displayed, but should mutt_any_key_to_continue() be called? A previous bugfix in another part of smime.c mentioned that this is bad, and it added a sleep(5) call whose purpose i didn't understand

Re: S/MIME display bug

2002-02-26 Thread David Collantes
On Tue, Feb 26, 2002 at 12:20:33PM +0100, Oliver Ehli wrote: alternatively, we could just printf() the first (ie _not_ use mutt_error), wait for any_key, and then mutt_error() the second/final warning. What about only the sleep? The continue garbles my screen here, for some reason. I just

Re: S/MIME display bug

2002-02-26 Thread Oliver Ehli
On Tue, Feb 26, 2002 at 11:24:56AM -0500, David Collantes wrote: What about only the sleep? The continue garbles my screen here, for some reason. I just patched with your diff, which got some rejection, btw. I would make it sleep for, lets say, 3 seconds and then to the mutt_error(). i think

Re: S/MIME display bug

2002-02-26 Thread Oliver Ehli
On Tue, Feb 26, 2002 at 11:52:49AM +, Luke Ross wrote: How about a red line in the status bar? Would be most elegent surely? that's what mutt_error does. I'm still on old S/MIME mutt, and I saw: [ ... something ... ] What was the reason behind changing it? No screen corruption here.