[Mypaint-discuss] Adding a lock alpha feature

2010-09-03 Thread k.guc...@gmail.com
Hi I would like to know what are your preferences regarding how to integrate a different code path in draw_dab, to make this feature possible: http://gitorious.org/mypaint/lockalpha/commit/5c7e92dac614c7fa73b60d2d66c44527fdc480e9 Of course, if you think it is crap and you do not want it in MyPai

Re: [Mypaint-discuss] Adding a lock alpha feature

2010-09-03 Thread k.guc...@gmail.com
2010/9/3 Martin Renold : > On Fri, Sep 03, 2010 at 10:46:44AM +0000, k.guc...@gmail.com wrote: >> http://gitorious.org/mypaint/lockalpha/commit/5c7e92dac614c7fa73b60d2d66c44527fdc480e9 >> >> Of course, if you think it is crap and you do not want it in MyPaint, >> j

Re: [Mypaint-discuss] Adding a lock alpha feature

2010-09-03 Thread k.guc...@gmail.com
OK, so I made this thing with templates to allow different blend modes in draw_dab(), they should be inlined automagically by g++. Any insights about this approach? Is this something you could accept for mainline MyPaint code? http://gitorious.org/~guciek/mypaint/lockalpha/commit/979acc050d95e4bb6

Re: [Mypaint-discuss] Adding a lock alpha feature

2010-09-04 Thread k.guc...@gmail.com
> Gives you a new brushsetting "lock alpha" to smoothly choose between locked > and non-locked alpha channel (and of course, it may depend on any brush > input).  The rest of the GUI support could be implemented along the lines of > eraser mode, I think. Here's why I think this should NOT be a bru

Re: [Mypaint-discuss] Adding a lock alpha feature

2010-09-04 Thread k.guc...@gmail.com
I just thought that "Eraser Mode" might be one of blend modes, so maybe at the GUI side it would be nice to just replace "Toggle Eraser Mode" with "Choose Blend Mode": http://github.com/guciek/mypaint/commit/a9a3a2470e97f4619242857c59979ae7969136be I think that this way MyPaint the code could be st

Re: [Mypaint-discuss] Adding a lock alpha feature

2010-09-05 Thread k.guc...@gmail.com
OK, so here it is working your way + changed handling of erasing in draw_dab() as a blend mode: http://github.com/guciek/mypaint/commits/blend_modes/ >> 1) there might be other blending modes, like those in the code you >> linked to, implemented in the future, and it is not sensible to turn >> mo

Re: [Mypaint-discuss] Adding a lock alpha feature

2010-09-05 Thread k.guc...@gmail.com
> I found some very ugly bug, though: when I select a brush, sometimes it is > not completely restored, eg.  I select the round "bulk" brush, and the brush > stroke does change in some way but it stays elliptical.  I hope it's only in > your branch; I did not find it at a quick glance through your