Sergei Golubchik wrote:
Though your changes looked innocent - that is they most probably could
do no harm - I failed to understand when they'll do any good.
You replaced a set of checks for buffer overflow by some other set of
checks, which looked equivalent to the old one.
Hi,
it turns out that
Sergei Golubchik wrote:
Ok, I took a look at this.
(btw, this was not a diff at all, but rather tarball of new and old
files. Having a real unified diff would make your changes MUCH easier to
understand).
Hi,
I did not want to force a particular diff format on the reader;
having the original and
Sergei Golubchik wrote:
On Mar 12, Maarten LITMAATH wrote:
Description:
MySQL (e.g. version 4.0.10-gamma) does not check for buffer overflows
when formatting error messages: the code just assumes that no message
will ever be larger than SC_MAXWIDTH (256), ERRMSGSIZE (SC_MAXWIDTH
between the original and the patched versions.
These fixes appeared to be sufficient to prevent memory corruption in
my use cases.
Submitter-Id: unknown
Originator: Maarten LITMAATH
Organization: CERN - European Laboratory for Particle Physics
MySQL support: none
Synopsis: error
