Re: [mythtv] [PATCH] mythmusic: autoplay of CDs

2005-05-14 Thread Herman Kuiper
Look mum - no spaces! :-) Herman - Herman Kuiper - m: [EMAIL PROTECTED] - w: http://www.frontier.nl Beech Ave 162 - 1119 PS Schiphol-Rijk - t/f: 020-6589034/6142816 autoplay.diff Description: Binary data _

Re: [mythtv] [PATCH] mythmusic: autoplay of CDs

2005-05-03 Thread Herman Kuiper
Hmmm - are there CVS diff switches which will ignore lines with whitespace-changes-only, but which will keep indentation etc? My editor stripped all trailing spaces (and removed some remaining tabs/spaces at empty lines) - hence the amount of "changes"... Perhaps you should switch to an editor that

Re: [mythtv] [PATCH] mythmusic: autoplay of CDs

2005-05-03 Thread Isaac Richards
On Tuesday 03 May 2005 03:53 am, Herman Kuiper wrote: > > Of course, if you ignore whitespace, you can't go editing random other > > code. There's too many unnecessary changes in this patch. > > Hmmm - are there CVS diff switches which will ignore lines with > whitespace-changes-only, but which w

Re: [mythtv] [PATCH] mythmusic: autoplay of CDs

2005-05-03 Thread Herman Kuiper
Of course, if you ignore whitespace, you can't go editing random other code. There's too many unnecessary changes in this patch. Hmmm - are there CVS diff switches which will ignore lines with whitespace-changes-only, but which will keep indentation etc? My editor stripped all trailing spaces (

Re: [mythtv] [PATCH] mythmusic: autoplay of CDs

2005-05-03 Thread Isaac Richards
On Sunday 10 April 2005 09:43 am, Herman Kuiper wrote: > Hi, > > > Not applying this, because: > > - it was generated with -b -B, which completely trashes the indentation > > of a few changes you made. > > Ah ok, I didn't know that. Of course, if you ignore whitespace, you can't go editing random

Re: [mythtv] [PATCH] mythmusic: autoplay of CDs

2005-04-24 Thread Herman Kuiper
[Using this thread, but it applies to my other patches as well] With 0.18 out of the way, I thought it might be a nice time to apply my patches, before 0.19 will come along :-) Herman - Herman Kuiper - m: [EMAIL PROTECTED] -

Re: [mythtv] [PATCH] mythmusic: autoplay of CDs

2005-04-10 Thread Herman Kuiper
Hi, Not applying this, because: - it was generated with -b -B, which completely trashes the indentation of a few changes you made. Ah ok, I didn't know that. - it duplicates quite a bit of code into playbackbox.cpp Do you mean: "within playbackbox.cpp" - if so, I further removed some duplicity. I

Re: [mythtv] [PATCH] mythmusic: autoplay of CDs

2005-04-09 Thread Isaac Richards
On Sunday 03 April 2005 02:47 pm, Herman Kuiper wrote: > I'll confess that I never use "Edit playlists", as I more or less don't get > the point of that screen, when you also have the playbackbox. Fixed as well > though. Not applying this, because: - it was generated with -b -B, which completely t

Re: [mythtv] [PATCH] mythmusic: autoplay of CDs

2005-04-03 Thread Herman Kuiper
Thanks for the feedback. Playlist::fillSongsFromCD Is missing the last track. Should have seen that :-) If you then go to "Edit Playlists", the Active Play Queue has a load of 'Missing Database Entry' entries. I'll confess that I never use "Edit playlists", as I more or less don't get the point o

Re: [mythtv] [PATCH] mythmusic: autoplay of CDs

2005-04-03 Thread Stutty
On Apr 1, 2005 11:14 PM, Herman Kuiper <[EMAIL PROTECTED]> wrote: > > Feedback welcome, > > Herman > Excellent, never understood why it was such a pain to play CD's, not that I have any that aren't ripped to MP3 now! One minor bug: Playlist::fillSongsFromCD Is missing the last track.

[mythtv] [PATCH] mythmusic: autoplay of CDs

2005-04-01 Thread Herman Kuiper
Attached patch adds a setting to MythMusic, when set, will start playing an inserted audio CD automatically. Also, an option has been added to the menu (M), from which you start playing an inserted CD immediately without going through the Edit playlist screen. This latter option is mainly usefu