> >I think there is other logic that would need to be changed later in the
> >analysis code to account for these frames, but this might fix it for
> >your test case.
> It does in fact fix this. Perfect commercial skip.
Great. I have this patch along with the other nuppeldecoder.cpp line
uncomme
Chris Pinkham wrote:
This could be because the patch pretends the skipped frames were blank.
Maybe that is a bad thing since it could cause false detection. I think
I need to put in some more logic to make it so that these skipped frames
do not affect the detection logic, but if you want to try
> Ok. I applied this patch and the uncomment change to my remote frontend
> (for completeness, this is does *not* include the change we made before
> to initialize framesPlayed and use an incrementer). I noted the cutlist
> that was generated by the previous run of mythcommflag and I ran the
Chris Pinkham wrote:
Could this have been broken for almost a year? When the changes were
put in to have NVP get framesPlayed from videoOutput, the line below
was commented out in nuppeldecoder.cpp. This is in changeset 4908.
http://cvs.mythtv.org/trac/changeset/4908
else if (frame
> >If the frame numbers in the editor match the frame numbers in the commercial
> >skip list, and the frame numbers displayed when AutoCommercialSkip skips
> >match those as well, then the frame number during playback must not be
> >matching the frame number you see when in edit mode (or when the f
Chris Pinkham wrote:
Just put the existing AutoCommercialSkip(); inside a block and put a
couple cerr's before and after it to print out the above values and
see how they compare to what you're seeing in the editor. See if it
looks like it skipped at the right frame number or if maybe it thinks
> >Just put the existing AutoCommercialSkip(); inside a block and put a
> >couple cerr's before and after it to print out the above values and
> >see how they compare to what you're seeing in the editor. See if it
> >looks like it skipped at the right frame number or if maybe it thinks
> >it's ski
> I'll see if I can get you something tonight, btw, do you have a way to
> see frame numbers in the editor or is converting somethingl like
> 0:23:59:09 to a frame number using 30fps the correct way?
The theme I uses displays the frame number in the OSD while in edit
mode, guess yours doesn't.
Chris Pinkham wrote:
If the frame numbers match up (so commercial detection is correct),
you can put some debug statements into
NuppelVideoPlayer::AutoCommercialSkip() to see if this is being
triggered early for some reason or if frame numbers look off in
there for some reason.
They do s
Chris Pinkham wrote:
If the frame numbers match up (so commercial detection is correct),
you can put some debug statements into
NuppelVideoPlayer::AutoCommercialSkip() to see if this is being
triggered early for some reason or if frame numbers look off in
there for some reason.
They do s
> >If the frame numbers match up (so commercial detection is correct),
> >you can put some debug statements into
> >NuppelVideoPlayer::AutoCommercialSkip() to see if this is being
> >triggered early for some reason or if frame numbers look off in
> >there for some reason.
> >
> They do seem to matc
Chris Pinkham wrote:
I'm having an issue recently. My commercial detection seems to detect
perfectly (duration wise) but the commercial skips about 5-15 seconds
early. So I miss 5-15 seconds prior to each break and see about 5-15
seconds of the last commercial. The clocks on both machines a
Chris Pinkham wrote:
Chris, this problem has existed for a long time with software encoding
but I hadn't ever wanted to bother you with it. If a file is damaged
by a pegged CPU, temporary loss of signal or any other reason that
might cause a significant number of dropped frames, the commercial
m
> Chris, this problem has existed for a long time with software encoding
> but I hadn't ever wanted to bother you with it. If a file is damaged
> by a pegged CPU, temporary loss of signal or any other reason that
> might cause a significant number of dropped frames, the commercial
> markers will be
Chris Pinkham wrote:
I'm having an issue recently. My commercial detection seems to detect
perfectly (duration wise) but the commercial skips about 5-15 seconds
early. So I miss 5-15 seconds prior to each break and see about 5-15
seconds of the last commercial. The clocks on both machines a
Bruce Markey wrote:
Chris Pinkham wrote:
I'm having an issue recently. My commercial detection seems to
detect perfectly (duration wise) but the commercial skips about 5-15
seconds early. So I miss 5-15 seconds prior to each break and see
about 5-15 seconds of the last commercial. The clo
Chris Pinkham wrote:
I'm having an issue recently. My commercial detection seems to detect
perfectly (duration wise) but the commercial skips about 5-15 seconds
early. So I miss 5-15 seconds prior to each break and see about 5-15
seconds of the last commercial. The clocks on both machines ar
> I'm having an issue recently. My commercial detection seems to detect
> perfectly (duration wise) but the commercial skips about 5-15 seconds
> early. So I miss 5-15 seconds prior to each break and see about 5-15
> seconds of the last commercial. The clocks on both machines are synced
> up
I'm having an issue recently. My commercial detection seems to detect
perfectly (duration wise) but the commercial skips about 5-15 seconds
early. So I miss 5-15 seconds prior to each break and see about 5-15
seconds of the last commercial. The clocks on both machines are synced
up to each o
19 matches
Mail list logo
