Nant or nantcontrib developers, I know that recent work is focused on getting .85 out the door, but if anyone could commit this patch, I would be much appreciated. I know that it isn't much of a patch.
Also, the patch was submitted to the nant patches instead of the nantcontrib patches...sorry. Jason >-----Original Message----- >From: [EMAIL PROTECTED] >[mailto:[EMAIL PROTECTED] On Behalf >Of Morris, Jason >Sent: Saturday, December 11, 2004 3:24 PM >To: [EMAIL PROTECTED] >Subject: [nant-dev] Request for version task patch be >committed (#1083618) > >Nant committers, > >I would like my patch (#1083618) that I submitted for the >NAntContrib <version> task be applied before the 0.85 release. > I mistakenly submitted the patch to the Nant patch tracker >instead of the NAntContrib patch tracker. > >The patch was to correct confusion that I and others on the >mailing list had with figuring out how to use the task. I >hope that this improves things. Also, the patch contains the >following changes: > >* Improved in-code documentation to avoid confusion that has >been expressed on the mailing list. >* Refactored code to remove duplication and make design simple >* Added several new properties > - Prefix.Major > - Prefix.Minor > - Prefix.Build > - Prefix.Revision >* Improve BuildType and RevisionType arguments > - Parsing is more forgiving because values are now case >insensitive. > - const defined for each argument value (no more >duplicated string compares) >* Added unit tests (separate patch) > >Patch was created by WinMerge which is GNU/diffutils >compatible from version 0.85rc1 (cvs version 1.7) > >Please let me know if there is anything that you require >before submitting this patch. > >Two other changes I would have made, but didn't since they >would have introduced breaking changes. One, the path >attribute should be renamed to the filename as that is more >appropriate description. Two, startDate attribute might be >renamed to startdate to maintain consistence with attribute >naming convention. > >Thanks, >Jason > > >------------------------------------------------------- >SF email is sponsored by - The IT Product Guide Read honest & >candid reviews on hundreds of IT Products from real users. >Discover which products truly live up to the hype. Start reading now. >http://productguide.itmanagersjournal.com/ >_______________________________________________ >nant-developers mailing list >[EMAIL PROTECTED] >https://lists.sourceforge.net/lists/listinfo/nant-developers > ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/ _______________________________________________ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
