Re: [nant-dev] PATCH: task w/read-only attribute destination

2003-03-03 Thread Matthew Mastracci
What about this one? I use the already-gotten dstInfo to test for attribute we don't want and clear them if they exist. Shouldn't be a lot of overhead in this case: diff -u -r1.4 CopyTask.cs --- src/NAnt.Core/Tasks/CopyTask.cs 26 Feb 2003 07:02:30 - 1.4 +++ src/NAnt.Core/Tasks/Cop

Re: [nant-dev] PATCH: task w/read-only attribute destination

2003-03-03 Thread Matthew Mastracci
Should I move the attribute setting bit to the earlier File.Exists test? This way, we should only have a single place to test it and the network overhead should only be a single attribute set per existing file. I may actually be able to retrieve all the file properties in one go and only set

Re: [nant-dev] PATCH: task w/read-only attribute destination

2003-03-03 Thread Philip Nelson
--- Matthew Mastracci <[EMAIL PROTECTED]> wrote: > This fixes the problem with read-only file destination for the > task. If noone objects, I'll check this in. snip > > if (File.Exists(dstPath)) > > File.SetAttributes(dstPath, > FileAttrib

[nant-dev] PATCH: task w/read-only attribute destination

2003-03-03 Thread Matthew Mastracci
This fixes the problem with read-only file destination for the task. If noone objects, I'll check this in. cvs server: Diffing src/NAnt.Core/Tasks Index: src/NAnt.Core/Tasks/CopyTask.cs === RCS file: /cvsroot/nant/nant/src/NAnt.Cor