Re: node.jar

2013-06-03 Thread Akhil Arora
Hi Brett On 05/30/2013 07:48 PM, Brett Wooldridge wrote: Akhil, Is the node.jar source available in a public repo somewhere? If not, when will it be? I'm trying to add nashorn support to vertx (http://vertx.io), which currently uses rhino, but it relies on the recent addition of commonjs supp

hg: nashorn/jdk8/nashorn: 8015814: loadWithNewGlobal needs to wrap createGlobal in AccessController.doPrivileged

2013-06-03 Thread james . laskey
Changeset: 0946c8a60f39 Author:jlaskey Date: 2013-06-03 12:57 -0300 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/0946c8a60f39 8015814: loadWithNewGlobal needs to wrap createGlobal in AccessController.doPrivileged Reviewed-by: sundar Contributed-by: james.las...@oracle.c

hg: nashorn/jdk8/nashorn: 8015796: Race condition in RuntimeCallsites

2013-06-03 Thread james . laskey
Changeset: 2df08f4c531d Author:jlaskey Date: 2013-06-03 11:16 -0300 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/2df08f4c531d 8015796: Race condition in RuntimeCallsites Reviewed-by: lagergren, attila Contributed-by: james.las...@oracle.com ! src/jdk/nashorn/internal/co

Review request 8015796 Race condition in RuntimeCallsites

2013-06-03 Thread Jim Laskey (Oracle)
http://cr.openjdk.java.net/~jlaskey/8015796/webrev.00/index.html

hg: nashorn/jdk8/nashorn: 8015741: Need a global.load function that starts with a new global scope.

2013-06-03 Thread james . laskey
Changeset: 08a8fda6c0bf Author:jlaskey Date: 2013-06-03 08:34 -0300 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/08a8fda6c0bf 8015741: Need a global.load function that starts with a new global scope. Reviewed-by: sundar, lagergren Contributed-by: james.las...@oracle.com

Re: Review request 8015345: Function("}), print('test'), ({") should throw SyntaxError

2013-06-03 Thread Jim Laskey (Oracle)
+1 On 2013-06-03, at 5:57 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8015345/ > > -Sundar

hg: nashorn/jdk8/nashorn: 8015345: Function("}), print('test'), ({") should throw SyntaxError

2013-06-03 Thread sundararajan . athijegannathan
Changeset: 295c91f5fdde Author:sundar Date: 2013-06-03 15:58 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/295c91f5fdde 8015345: Function("}),print('test'),({") should throw SyntaxError Reviewed-by: lagergren, hannesw, jlaskey ! src/jdk/nashorn/internal/objects/Nat

Re: Review request 8015345: Function("}), print('test'), ({") should throw SyntaxError

2013-06-03 Thread Hannes Wallnoefer
+1 Wondering if the additional parsing overhead could be something to worry about? Hannes Am 2013-06-03 10:57, schrieb A. Sundararajan: Please review http://cr.openjdk.java.net/~sundar/8015345/ -Sundar

Review request 8015345: Function("}), print('test'), ({") should throw SyntaxError

2013-06-03 Thread A. Sundararajan
Please review http://cr.openjdk.java.net/~sundar/8015345/ -Sundar