hg: nashorn/jdk8/nashorn: 8015346: JSON parsing issues with escaped strings, octal, decimal numbers

2013-06-06 Thread sundararajan . athijegannathan
Changeset: bab844827181 Author:sundar Date: 2013-06-06 21:41 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/bab844827181 8015346: JSON parsing issues with escaped strings, octal, decimal numbers Reviewed-by: hannesw, jlaskey ! src/jdk/nashorn/internal/ir/BlockLexica

Re: Review request for 8015346: JSON parsing issues with escaped strings, octal, decimal numbers

2013-06-06 Thread Hannes Wallnoefer
+1 Am 2013-06-06 17:13, schrieb A. Sundararajan: Please review http://cr.openjdk.java.net/~sundar/8015346/webrev.01/ Simplified scanNumber method of Lexer for JSONParser. -Sundar

Re: Review request for 8015346: JSON parsing issues with escaped strings, octal, decimal numbers

2013-06-06 Thread Jim Laskey (Oracle)
+1 On 2013-06-06, at 12:13 PM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8015346/webrev.01/ > > Simplified scanNumber method of Lexer for JSONParser. > > -Sundar

Review request for 8015346: JSON parsing issues with escaped strings, octal, decimal numbers

2013-06-06 Thread A. Sundararajan
Please review http://cr.openjdk.java.net/~sundar/8015346/webrev.01/ Simplified scanNumber method of Lexer for JSONParser. -Sundar

Re: Nashorn: Javascript to Java call question

2013-06-06 Thread A. Sundararajan
Previously, nashorn.jar used to have netscape.javascript.JSObject and ScriptObjectMirror used to extend that class. To avoid confusion with desktop profile's netscape.javascript.JSObject (and also avoid applet dependency on nashorn), we have renamed that class to jdk.nashorn.api.scripting.JSOb

Re: Nashorn: Javascript to Java call question

2013-06-06 Thread Mani Sarkar
Hi Jim, You have been very quick with your response to my query. Thanks for going through the trouble, apologies for the empty folders, they are submodules that haven;t been pushed correctly to my repo. I have made the changes you suggested and rebuilt my class (I had to get the latest version o

Review request for 8015346: JSON parsing issues with escaped strings, octal, decimal numbers

2013-06-06 Thread A. Sundararajan
Please review http://cr.openjdk.java.net/~sundar/8015346/ -Sundar