Re: Review request for 8015357: a = []; a[0x7fffffff]=1; a.sort()[0] should evaluate to 1 instead of undefined

2013-06-12 Thread Hannes Wallnoefer
+1 Am 2013-06-11 08:48, schrieb A. Sundararajan: Please review http://cr.openjdk.java.net/~sundar/8015357/ After the recent Array int/long consistency fixes, this issue is no longer reproduced. Adding a regression test for future. -Sundar

hg: nashorn/jdk8/nashorn: 8011893: JS Object builtin prototype is not thread safe

2013-06-12 Thread hannes . wallnoefer
Changeset: d26e069353c0 Author:hannesw Date: 2013-06-12 16:41 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/d26e069353c0 8011893: JS Object builtin prototype is not thread safe Reviewed-by: sundar, jlaskey ! src/jdk/nashorn/internal/runtime/PropertyListenerManager.

Review request JDK-8016453 loadWithNewGlobal does not allow apply operation

2013-06-12 Thread Jim Laskey (Oracle)
http://cr.openjdk.java.net/~jlaskey/8016453/webrev.00/

Re: Review request for JDK-8011893: JS Object builtin prototype is not thread safe

2013-06-12 Thread Jim Laskey (Oracle)
+1 On 2013-06-12, at 11:11 AM, Hannes Wallnoefer wrote: > Please review my webrev for JDK-8011893: JS Object builtin prototype is not > thread safe: > > http://cr.openjdk.java.net/~hannesw/8011893/ > > Thanks, > Hannes

Re: Review request for 8015357: a = []; a[0x7fffffff]=1; a.sort()[0] should evaluate to 1 instead of undefined

2013-06-12 Thread Jim Laskey (Oracle)
+1 On 2013-06-11, at 3:48 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8015357/ > > After the recent Array int/long consistency fixes, this issue is no longer > reproduced. Adding a regression test for future. > > -Sundar

hg: nashorn/jdk8/nashorn: 8016453: loadWithNewGlobal does not allow apply operation

2013-06-12 Thread james . laskey
Changeset: aa16622193e1 Author:jlaskey Date: 2013-06-12 11:22 -0300 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/aa16622193e1 8016453: loadWithNewGlobal does not allow apply operation Reviewed-by: hannesw, sundar Contributed-by: james.las...@oracle.com ! samples/test.js

Re: Review request for JDK-8011893: JS Object builtin prototype is not thread safe

2013-06-12 Thread A. Sundararajan
+1 On Wednesday 12 June 2013 07:41 PM, Hannes Wallnoefer wrote: Please review my webrev for JDK-8011893: JS Object builtin prototype is not thread safe: http://cr.openjdk.java.net/~hannesw/8011893/ Thanks, Hannes

Review request for JDK-8011893: JS Object builtin prototype is not thread safe

2013-06-12 Thread Hannes Wallnoefer
Please review my webrev for JDK-8011893: JS Object builtin prototype is not thread safe: http://cr.openjdk.java.net/~hannesw/8011893/ Thanks, Hannes