hg: nashorn/jdk8/nashorn: 8016542: String.prototype.replace called with function argument should not replace $ patterns

Changeset: c5f783d83180 Author:hannesw Date: 2013-06-13 20:50 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/c5f783d83180 8016542: String.prototype.replace called with function argument should not replace $ patterns Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn

hg: nashorn/jdk8/nashorn: 8016528: Hex code from escape() should be padded

Changeset: fe80eda7b57e Author:hannesw Date: 2013-06-13 15:26 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/fe80eda7b57e 8016528: Hex code from escape() should be padded Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/runtime/GlobalFunctions.java + test/

Re: Review request for JDK-8016522: Numeric literal must not be followed by IdentifierStart

+1 On 2013-06-13, at 8:41 AM, Hannes Wallnoefer wrote: > Please review JDK-8016522: Numeric literal must not be followed by > IdentifierStart: > > http://cr.openjdk.java.net/~hannesw/8016522/ > > Thanks, > Hannes

Re: Review request for JDK-8016522: Numeric literal must not be followed by IdentifierStart

+1 On Thursday 13 June 2013 05:11 PM, Hannes Wallnoefer wrote: Please review JDK-8016522: Numeric literal must not be followed by IdentifierStart: http://cr.openjdk.java.net/~hannesw/8016522/ Thanks, Hannes

hg: nashorn/jdk8/nashorn: 8016522: Numeric literal must not be followed by IdentifierStart

Changeset: 18362e95e638 Author:hannesw Date: 2013-06-13 14:02 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/18362e95e638 8016522: Numeric literal must not be followed by IdentifierStart Reviewed-by: lagergren, sundar ! src/jdk/nashorn/internal/parser/Lexer.java ! s

Review request for JDK-8016522: Numeric literal must not be followed by IdentifierStart

Please review JDK-8016522: Numeric literal must not be followed by IdentifierStart: http://cr.openjdk.java.net/~hannesw/8016522/ Thanks, Hannes

Re: Review request for JDK-8016518: Parsing of octal string escapes is broken

+1 On 2013-06-13, at 7:42 AM, Hannes Wallnoefer wrote: > Please review JDK-8016518: Parsing of octal string escapes is broken: > > http://cr.openjdk.java.net/~hannesw/8016518/ > > Thanks, > Hannes

Re: Review request for 8015355: Array.prototype functions don't honour non-writable length and / or index properties

+1 On 2013-06-13, at 6:20 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8015355/ > > -Sundar

hg: nashorn/jdk8/nashorn: 8015355: Array.prototype functions don't honour non-writable length and / or index properties

Changeset: b0dcc3727fc3 Author:sundar Date: 2013-06-13 16:08 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/b0dcc3727fc3 8015355: Array.prototype functions don't honour non-writable length and / or index properties Reviewed-by: lagergren, hannesw ! src/jdk/nashorn/

hg: nashorn/jdk8/nashorn: 8016518: Parsing of octal string escapes is broken

Changeset: 6d6133ef1fd5 Author:hannesw Date: 2013-06-13 12:52 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/6d6133ef1fd5 8016518: Parsing of octal string escapes is broken Reviewed-by: sundar, lagergren ! src/jdk/nashorn/internal/parser/Lexer.java + test/script/bas

Re: Review request for JDK-8016518: Parsing of octal string escapes is broken

+1 On Thursday 13 June 2013 04:12 PM, Hannes Wallnoefer wrote: Please review JDK-8016518: Parsing of octal string escapes is broken: http://cr.openjdk.java.net/~hannesw/8016518/ Thanks, Hannes

Review request for JDK-8016518: Parsing of octal string escapes is broken

Please review JDK-8016518: Parsing of octal string escapes is broken: http://cr.openjdk.java.net/~hannesw/8016518/ Thanks, Hannes

Review request for 8015355: Array.prototype functions don't honour non-writable length and / or index properties

Please review http://cr.openjdk.java.net/~sundar/8015355/ -Sundar