hg: nashorn/jdk8/nashorn: 8016618: script mirror object access should be improved

2013-06-14 Thread sundararajan . athijegannathan
Changeset: 3d947baa33cc Author:sundar Date: 2013-06-14 21:16 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/3d947baa33cc 8016618: script mirror object access should be improved Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java !

Re: Review request for 8016618: script mirror object access should be improved

2013-06-14 Thread Jim Laskey (Oracle)
+1 On 2013-06-14, at 10:38 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8016618/ > > -Sundar

Review request for 8016618: script mirror object access should be improved

2013-06-14 Thread A. Sundararajan
Please review http://cr.openjdk.java.net/~sundar/8016618/ -Sundar

hg: nashorn/jdk8/nashorn: 8016235: Use in catch block that may not have been executed in try block caused illegal byte code to be generated

2013-06-14 Thread marcus . lagergren
Changeset: 3efa56767847 Author:lagergren Date: 2013-06-14 13:53 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/3efa56767847 8016235: Use in catch block that may not have been executed in try block caused illegal byte code to be generated Reviewed-by: jlaskey, hannes

Re: Please review JDK-8016235

2013-06-14 Thread Jim Laskey (Oracle)
+1 On 2013-06-14, at 8:23 AM, Marcus Lagergren wrote: > Please review: http://cr.openjdk.java.net/~lagergren/8016235/ , > Jean-Francois's bug when a catch block uses something that need not > necessarily have been defined in the try block, causing illegal bytecode to > be generated > > /M >

Please review JDK-8016235

2013-06-14 Thread Marcus Lagergren
Please review: http://cr.openjdk.java.net/~lagergren/8016235/ , Jean-Francois's bug when a catch block uses something that need not necessarily have been defined in the try block, causing illegal bytecode to be generated /M