Re: Review request JDK-8010697 -DeletedArrayFilter seems to leak memory

2013-06-18 Thread A. Sundararajan
+1 On Tuesday 18 June 2013 10:43 PM, Jim Laskey (Oracle) wrote: http://cr.openjdk.java.net/~jlaskey/8010697/webrev.00/

Review request JDK-8010697 -DeletedArrayFilter seems to leak memory

2013-06-18 Thread Jim Laskey (Oracle)
http://cr.openjdk.java.net/~jlaskey/8010697/webrev.00/

Re: Review request 8012698: [nashorn] tests fail to run with agentvm or samevm

2013-06-18 Thread Jim Laskey (Oracle)
+1 On 2013-06-18, at 9:54 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8012698/ > > -Sundar

hg: nashorn/jdk8/nashorn: 8012698: [nashorn] tests fail to run with agentvm or samevm

2013-06-18 Thread sundararajan . athijegannathan
Changeset: 6a75a505301f Author:sundar Date: 2013-06-18 18:43 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/6a75a505301f 8012698: [nashorn] tests fail to run with agentvm or samevm Reviewed-by: hannesw, jlaskey ! test/src/jdk/nashorn/api/javaaccess/BooleanAccessTest

Re: Review request 8012698: [nashorn] tests fail to run with agentvm or samevm

2013-06-18 Thread Hannes Wallnoefer
+1 Am 2013-06-18 14:54, schrieb A. Sundararajan: Please review http://cr.openjdk.java.net/~sundar/8012698/ -Sundar

Review request 8012698: [nashorn] tests fail to run with agentvm or samevm

2013-06-18 Thread A. Sundararajan
Please review http://cr.openjdk.java.net/~sundar/8012698/ -Sundar

Re: Review request for 8008915: URLReader constructor should allow specifying encoding

2013-06-18 Thread Jim Laskey (Oracle)
+1 On 2013-06-18, at 1:17 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8008915/ > > -Sundar

hg: nashorn/jdk8/nashorn: 8008915: URLReader constructor should allow specifying encoding

2013-06-18 Thread sundararajan . athijegannathan
Changeset: 616ab697fcac Author:sundar Date: 2013-06-18 13:45 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/616ab697fcac 8008915: URLReader constructor should allow specifying encoding Reviewed-by: hannesw, lagergren ! src/jdk/nashorn/api/scripting/NashornScriptEngi

Re: Review request for 8008915: URLReader constructor should allow specifying encoding

2013-06-18 Thread Hannes Wallnoefer
+1 Am 2013-06-18 06:17, schrieb A. Sundararajan: Please review http://cr.openjdk.java.net/~sundar/8008915/ -Sundar