Please review http://cr.openjdk.java.net/~sundar/8019226/
-Sundar
Changeset: d1886ad46f0c
Author:jlaskey
Date: 2013-06-26 12:38 -0300
URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/d1886ad46f0c
8019175: Simplify ScriptObject.modifyOwnProperty
Reviewed-by: hannesw
Contributed-by: james.las...@oracle.com
! src/jdk/nashorn/internal/objects
On 2013-06-25, at 5:11 PM, Ivo Houbrechts wrote:
>> Thanks for the heads up. JDK8 is only API frozen, so we have some time to
>> address performance issues as they come up. There are some fixes in the
>> pipe that will address some of the things I see here, but we should examine
>> in more
Changeset: 635098f9f45e
Author:sundar
Date: 2013-06-26 19:42 +0530
URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/635098f9f45e
8014781: support Error.captureStackTrace
Reviewed-by: jlaskey, hannesw
! src/jdk/nashorn/api/scripting/NashornException.java
! src/jdk/nashorn/in
+1
Am 2013-06-26 15:30, schrieb A. Sundararajan:
Please review http://cr.openjdk.java.net/~sundar/8014781/
-Sundar
+1
On 2013-06-26, at 10:30 AM, A. Sundararajan
wrote:
> Please review http://cr.openjdk.java.net/~sundar/8014781/
>
> -Sundar
Changeset: 80c66d3fd872
Author:hannesw
Date: 2013-06-26 15:40 +0200
URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/80c66d3fd872
8019157: Avoid calling ScriptObject.setProto() if possible
Reviewed-by: jlaskey, sundar
! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasge
Please review http://cr.openjdk.java.net/~sundar/8014781/
-Sundar
+1
On Wednesday 26 June 2013 04:42 PM, Jim Laskey (Oracle) wrote:
+1
On 2013-06-26, at 6:44 AM, Hannes Wallnoefer
wrote:
Please review JDK-8019157 - Avoid calling ScriptObject.setProto() if possible:
http://cr.openjdk.java.net/~hannesw/8019157/
Bug description pasted below for your conven
Changeset: 682889823712
Author:jlaskey
Date: 2013-06-26 08:36 -0300
URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/682889823712
8008458: Strict functions dont share property map
Reviewed-by: sundar, hannesw
Contributed-by: james.las...@oracle.com
! src/jdk/nashorn/interna
+1
On 2013-06-26, at 6:44 AM, Hannes Wallnoefer
wrote:
> Please review JDK-8019157 - Avoid calling ScriptObject.setProto() if possible:
>
> http://cr.openjdk.java.net/~hannesw/8019157/
>
> Bug description pasted below for your convenience.
>
> Calling ScriptObject.setProto() is quite expensi
Removed __stack__ property for getStackTrace()
For 'stack' property, we want user code to "override" our getter/setter
based retrieval of stack string -- with whatever value they'd like to
provide.
-Sundar
On Wednesday 26 June 2013 03:11 PM, Hannes Wallnoefer wrote:
Both the Error stack prop
Changeset: 39e17373d8df
Author:sundar
Date: 2013-06-26 16:36 +0530
URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/39e17373d8df
8017950: error.stack should be a string rather than an array
Reviewed-by: hannesw, jlaskey
! src/jdk/nashorn/internal/objects/NativeError.java
!
+1
On 2013-06-26, at 5:27 AM, A. Sundararajan
wrote:
> Please review http://cr.openjdk.java.net/~sundar/8017950/
>
> -Sundar
Please review JDK-8019157 - Avoid calling ScriptObject.setProto() if
possible:
http://cr.openjdk.java.net/~hannesw/8019157/
Bug description pasted below for your convenience.
Calling ScriptObject.setProto() is quite expensive. One expensive part
is invalidating the object's property map, whic
Both the Error stack property and the getStackTrace() method seem to
return the __stack__ property if it is defined. Shouldn't that only be
used for the stack property?
Generally I'm wondering if there isn't a better solution for a
rewritable getter than to use a hidden property. I'll try a fe
Please review http://cr.openjdk.java.net/~sundar/8017950/
-Sundar
17 matches
Mail list logo
