hg: nashorn/jdk8/nashorn: 8011629: Object.defineProperty performance issue

2013-07-03 Thread james . laskey
Changeset: 7b072ebdf5aa Author:jlaskey Date: 2013-07-03 13:41 -0300 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/7b072ebdf5aa 8011629: Object.defineProperty performance issue Reviewed-by: sundar, attila Contributed-by: james.las...@oracle.com ! src/jdk/nashorn/internal/

Re: Review request: JDK-8011629: Object.defineProperty performance issue

2013-07-03 Thread A. Sundararajan
+1 On Wednesday 03 July 2013 10:05 PM, Jim Laskey (Oracle) wrote: Please review http://cr.openjdk.java.net/~jlaskey/8011629/webrev.00/ This casts (asType) the receiver early so that the same getter/setter can be reused. Speeds up defineProperty and indexed access and reduces lambda form pressu

Review request: JDK-8011629: Object.defineProperty performance issue

2013-07-03 Thread Jim Laskey (Oracle)
Please review http://cr.openjdk.java.net/~jlaskey/8011629/webrev.00/ This casts (asType) the receiver early so that the same getter/setter can be reused. Speeds up defineProperty and indexed access and reduces lambda form pressure (over 1M in the above example).

Re: Review request for JDK-8017768

2013-07-03 Thread Attila Szegedi
disregard this - sent twice accidentally… On Jul 3, 2013, at 6:09 PM, Attila Szegedi wrote: > Please review JDK-8017768 at > http://cr.openjdk.java.net/~attila/8017768/webrev.00 > > Thanks, > Attila.

hg: nashorn/jdk8/nashorn: 8017768: allow dot as inner class name separator for Java.type

2013-07-03 Thread attila . szegedi
Changeset: 29b2b2ed954c Author:attila Date: 2013-07-03 18:10 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/29b2b2ed954c 8017768: allow dot as inner class name separator for Java.type Reviewed-by: jlaskey, sundar ! docs/JavaScriptingProgrammersGuide.html ! src/jdk/n

Review request for JDK-8017768

2013-07-03 Thread Attila Szegedi
Please review JDK-8017768 at http://cr.openjdk.java.net/~attila/8017768/webrev.00 Thanks, Attila.

Re: Review request for JDK-8017768

2013-07-03 Thread Jim Laskey (Oracle)
+1 On 2013-07-03, at 11:42 AM, Attila Szegedi wrote: > Please review JDK-8017768 at > http://cr.openjdk.java.net/~attila/8017768/webrev.00 > > Thanks, > Attila.

Re: Review request for JDK-8017768

2013-07-03 Thread A. Sundararajan
+1 On Wednesday 03 July 2013 08:12 PM, Attila Szegedi wrote: Please review JDK-8017768 at http://cr.openjdk.java.net/~attila/8017768/webrev.00 Thanks, Attila.

Review request for JDK-8017768

2013-07-03 Thread Attila Szegedi
Please review JDK-8017768 at http://cr.openjdk.java.net/~attila/8017768/webrev.00 Thanks, Attila.

Re: Review request for 8019814: Add regression test for passing cases

2013-07-03 Thread Jim Laskey (Oracle)
+1 On 2013-07-03, at 10:42 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8019814/ > > -Sundar

hg: nashorn/jdk8/nashorn: 8019814: Add regression test for passing cases

2013-07-03 Thread sundararajan . athijegannathan
Changeset: fcb484c43348 Author:sundar Date: 2013-07-03 19:20 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/fcb484c43348 8019814: Add regression test for passing cases Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/runtime/ListAdapter.java + test/script/

Review request for 8019814: Add regression test for passing cases

2013-07-03 Thread A. Sundararajan
Please review http://cr.openjdk.java.net/~sundar/8019814/ -Sundar

hg: nashorn/jdk8/nashorn: 8019811: Static calls - self referential functions needed a return type conversion if they were specialized, as they can't use the same mechanism as indy calls

2013-07-03 Thread marcus . lagergren
Changeset: 961cffae0828 Author:lagergren Date: 2013-07-03 15:46 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/961cffae0828 8019811: Static calls - self referential functions needed a return type conversion if they were specialized, as they can't use the same mechan

Re: Review request for 8019805: for each (init; test; modify) is invalid

2013-07-03 Thread Jim Laskey (Oracle)
+1 On 2013-07-03, at 8:54 AM, "A. Sundararajan" wrote: > Please review http://cr.openjdk.java.net/~sundar/8019805/ > > -Sundar

hg: nashorn/jdk8/nashorn: 8019805: for each (init; test; modify) is invalid

2013-07-03 Thread sundararajan . athijegannathan
Changeset: eb1437d16ab4 Author:sundar Date: 2013-07-03 17:26 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/eb1437d16ab4 8019805: for each (init; test; modify) is invalid Reviewed-by: lagergren, jlaskey ! src/jdk/nashorn/internal/parser/Parser.java ! src/jdk/nashorn

Review request for 8019805: for each (init; test; modify) is invalid

2013-07-03 Thread A. Sundararajan
Please review http://cr.openjdk.java.net/~sundar/8019805/ -Sundar

hg: nashorn/jdk8/nashorn: 8019585: Sometimes a var declaration using itself in its init wasn't declared as canBeUndefined, causing erroneous bytecode

2013-07-03 Thread marcus . lagergren
Changeset: b1980b5f00a1 Author:lagergren Date: 2013-07-03 13:03 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/b1980b5f00a1 8019585: Sometimes a var declaration using itself in its init wasn't declared as canBeUndefined, causing erroneous bytecode Reviewed-by: sunda

hg: nashorn/jdk8/nashorn: 8010946: AccessControl.doPrivileged is broken when called from js script

2013-07-03 Thread attila . szegedi
Changeset: 18d467e94150 Author:attila Date: 2013-07-03 12:39 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/18d467e94150 8010946: AccessControl.doPrivileged is broken when called from js script Reviewed-by: jlaskey, sundar ! make/build.xml ! src/jdk/internal/dynalin

Re: Review request for 8019791: ~ is a unary operator

2013-07-03 Thread Jim Laskey (Oracle)
+1 On 2013-07-03, at 5:23 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8019791/ > > -Sundar

hg: nashorn/jdk8/nashorn: 8019791: ~ is a unary operator

2013-07-03 Thread sundararajan . athijegannathan
Changeset: 4afdc5bec43b Author:sundar Date: 2013-07-03 14:08 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/4afdc5bec43b 8019791: ~ is a unary operator Reviewed-by: hannesw ! src/jdk/nashorn/internal/parser/TokenType.java + test/script/basic/JDK-8019791.js + test/sc

Re: Review request for 8019791: ~ is a unary operator

2013-07-03 Thread Hannes Wallnoefer
+1 Am 2013-07-03 10:23, schrieb A. Sundararajan: Please review http://cr.openjdk.java.net/~sundar/8019791/ -Sundar

Review request for 8019791: ~ is a unary operator

2013-07-03 Thread A. Sundararajan
Please review http://cr.openjdk.java.net/~sundar/8019791/ -Sundar

hg: nashorn/jdk8/nashorn: 8019783: typeof does not work properly for java methods and foreign objects

2013-07-03 Thread sundararajan . athijegannathan
Changeset: 9d3a9fdab668 Author:sundar Date: 2013-07-03 13:13 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/9d3a9fdab668 8019783: typeof does not work properly for java methods and foreign objects Reviewed-by: hannesw ! src/jdk/nashorn/internal/runtime/JSType.java !

Re: New batch of error reports

2013-07-03 Thread A. Sundararajan
I forgot to mention. Nashorn has --no-syntax-extensions / -nse option (default: false) - which switches off all syntactic extensions such as unnamed-function-decls, for..each, anon-class-like new ( new java.lang.Runnable() { run: function() { .. } }), closure expressions etc. -Sundar On Wedn

Re: New batch of error reports

2013-07-03 Thread André Bargull
On 7/3/2013 8:37 AM, A. Sundararajan wrote: * Yes - function-declaration-as-statement is allowed in nashorn for compatibility with other impls. nashorn jjs tool has these 2 options: --function-statement-error (Report an error when function declaration is used as a statement.) param: