Re: Review request for 8019947: inherited property invalidation does not work with two globals in same context

2013-07-04 Thread Marcus Lagergren
If there are no performance regressions +1 /M On Jul 4, 2013, at 9:25 PM, "A. Sundararajan" wrote: > Please review http://cr.openjdk.java.net/~sundar/8019947/ > > Tests and test262 tests pass. uglify.js passed (tested by JF) > > -Sundar

Review request for 8019947: inherited property invalidation does not work with two globals in same context

2013-07-04 Thread A. Sundararajan
Please review http://cr.openjdk.java.net/~sundar/8019947/ Tests and test262 tests pass. uglify.js passed (tested by JF) -Sundar

Re: Review request for JDK-8019809

2013-07-04 Thread Jim Laskey (Oracle)
+1 On 2013-07-04, at 8:53 AM, Attila Szegedi wrote: > Please review JDK-8019809 at > http://cr.openjdk.java.net/~attila/8019809/webrev.00 > > Thanks, > Attila.

hg: nashorn/jdk8/nashorn: 2 new changesets

2013-07-04 Thread marcus . lagergren
Changeset: be2087629eb9 Author:lagergren Date: 2013-07-04 17:27 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/be2087629eb9 8019821: allInteger switches were confused by boolean cases, as they are a narrower type than int Reviewed-by: sundar, hannesw ! src/jdk/nash

Re: Review request for JDK-8019819

2013-07-04 Thread Hannes Wallnoefer
Looks good. Hannes Am 2013-07-04 17:01, schrieb Attila Szegedi: Please review JDK-8019819 at http://cr.openjdk.java.net/~attila/8019819/webrev.00 Thanks, Attila.

Review request for JDK-8019819

2013-07-04 Thread Attila Szegedi
Please review JDK-8019819 at http://cr.openjdk.java.net/~attila/8019819/webrev.00 Thanks, Attila.

Re: Review request for JDK-8019809

2013-07-04 Thread Marcus Lagergren
+1 On Jul 4, 2013, at 1:55 PM, Attila Szegedi wrote: > Please review JDK-8019809 at > http://cr.openjdk.java.net/~attila/8019809/webrev.00 > > Thanks, > Attila.

hg: nashorn/jdk8/nashorn: 8019809: return after break incorrectly sets the block as terminal

2013-07-04 Thread attila . szegedi
Changeset: ad6b18ee4666 Author:attila Date: 2013-07-04 14:10 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/ad6b18ee4666 8019809: return after break incorrectly sets the block as terminal Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/codegen/Lower.java

Review request for JDK-8019809

2013-07-04 Thread Attila Szegedi
Please review JDK-8019809 at http://cr.openjdk.java.net/~attila/8019809/webrev.00 Thanks, Attila.

Review request for JDK-8019809

2013-07-04 Thread Attila Szegedi
Please review JDK-8019809 at http://cr.openjdk.java.net/~attila/8019809/webrev.00 Thanks, Attila.