hg: nashorn/jdk8/nashorn: 8019983: Void returns combined with return with expression picked the wrong return type

2013-07-05 Thread marcus . lagergren
Changeset: 20b2c2dc20e8 Author:lagergren Date: 2013-07-05 19:35 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/20b2c2dc20e8 8019983: Void returns combined with return with expression picked the wrong return type Reviewed-by: sundar, jlaskey ! src/jdk/nashorn/intern

Re: Please review http://cr.openjdk.java.net/~lagergren/8019983/

2013-07-05 Thread Jim Laskey (Oracle)
+1 On 2013-07-05, at 2:21 PM, Marcus Lagergren wrote: > return without expression combined with return WITH expressions produced the > wrong return type > > /M >

Please review http://cr.openjdk.java.net/~lagergren/8019983/

2013-07-05 Thread Marcus Lagergren
return without expression combined with return WITH expressions produced the wrong return type /M

hg: nashorn/jdk8/nashorn: 8019819: scope symbol didn't get a slot in certain cases

2013-07-05 Thread attila . szegedi
Changeset: ce9cbe70f915 Author:attila Date: 2013-07-05 15:10 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/ce9cbe70f915 8019819: scope symbol didn't get a slot in certain cases Reviewed-by: hannesw, jlaskey, lagergren, sundar ! src/jdk/nashorn/internal/codegen/Attr

hg: nashorn/jdk8/nashorn: 8017084: Use spill properties for large object literals

2013-07-05 Thread hannes . wallnoefer
Changeset: edca88d3a03e Author:hannesw Date: 2013-07-05 14:36 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/edca88d3a03e 8017084: Use spill properties for large object literals Reviewed-by: lagergren, sundar ! buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen

hg: nashorn/jdk8/nashorn: 8019947: inherited property invalidation does not work with two globals in same context

2013-07-05 Thread sundararajan . athijegannathan
Changeset: ec84ba68ad39 Author:sundar Date: 2013-07-05 14:38 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/ec84ba68ad39 8019947: inherited property invalidation does not work with two globals in same context Reviewed-by: jlaskey, lagergren, hannesw, attila ! make/

Review request for 8017084: Use spill properties for large object literals

2013-07-05 Thread Hannes Wallnoefer
Please review JDK-8017084: Use spill properties for large object literals: http://cr.openjdk.java.net/~hannesw/8017084/ This adds a SpillObjectCreator to allow creation of large/huge object literals in constant time. It also gives Richards a 20% boost by trying to use the right structure class

Re: Review request for 8019947: inherited property invalidation does not work with two globals in same context

2013-07-05 Thread A. Sundararajan
Please review updated webrev : http://cr.openjdk.java.net/~sundar/8019947/webrev.01/ Adjusted class loader code in Context, avoiding reflection to create Global, directly referring to objects.* classes in codegen, Context, using "MH" lookup in objects.* classes. -Sundar On Friday 05 July 201