Review request for 8014785: Ability to extend global instance by binding properties of another object

2013-07-08 Thread A. Sundararajan
Please review http://cr.openjdk.java.net/~sundar/8014785/ -Sundar

Re: Review request for JDK-8019963: empty char range in regex

2013-07-08 Thread Jim Laskey (Oracle)
+1 On 2013-07-08, at 1:42 PM, Hannes Wallnoefer wrote: > Please review JDK-8019963: empty char range in regex: > > http://cr.openjdk.java.net/~hannesw/8019963/ > > This basically removes unneeded code/features in Joni. > > Hannes

hg: nashorn/jdk8/nashorn: 8019963: empty char range in regex

2013-07-08 Thread hannes . wallnoefer
Changeset: 5106d43feed7 Author:hannesw Date: 2013-07-08 19:34 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/5106d43feed7 8019963: empty char range in regex Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/runtime/regexp/joni/CodeRangeBuffer.java ! src/jdk/na

Review request for JDK-8019963: empty char range in regex

2013-07-08 Thread Hannes Wallnoefer
Please review JDK-8019963: empty char range in regex: http://cr.openjdk.java.net/~hannesw/8019963/ This basically removes unneeded code/features in Joni. Hannes

hg: nashorn/jdk8/nashorn: 8020035: nashorn jdk buildfile BuildNashorn.gmk still renamed jdk.nashorn.internal.objects package

2013-07-08 Thread sundararajan . athijegannathan
Changeset: a75e75cc6a61 Author:sundar Date: 2013-07-08 18:36 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/a75e75cc6a61 8020035: nashorn jdk buildfile BuildNashorn.gmk still renamed jdk.nashorn.internal.objects package Reviewed-by: attila, jlaskey ! makefiles/Buil

Re: Please review http://cr.openjdk.java.net/~sundar/8020035/

2013-07-08 Thread Jim Laskey (Oracle)
+1 On 2013-07-08, at 10:08 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8020035/ > > -Sundar

Please review http://cr.openjdk.java.net/~sundar/8020035/

2013-07-08 Thread A. Sundararajan
Please review http://cr.openjdk.java.net/~sundar/8020035/ -Sundar

hg: nashorn/jdk8/nashorn: 8020015: shared PropertyMaps should not be used without duplication

2013-07-08 Thread sundararajan . athijegannathan
Changeset: 36d6b6a3fbe0 Author:sundar Date: 2013-07-08 16:33 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/36d6b6a3fbe0 8020015: shared PropertyMaps should not be used without duplication Reviewed-by: hannesw, attila ! buildtools/nasgen/build.xml ! buildtools/nasge