Review request for 8020224: LinkageError: attempted duplicate class definition when --loader-per-compiler=false

2013-07-09 Thread A. Sundararajan
Please review http://cr.openjdk.java.net/~sundar/8020224/ -Sundar

hg: nashorn/jdk8/nashorn: 8020124: In the case of an eval switch, we might need explicit conversions of the tag store, as it was not known in the surrounding environment.

2013-07-09 Thread marcus . lagergren
Changeset: d480015ab732 Author:lagergren Date: 2013-07-09 15:56 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/d480015ab732 8020124: In the case of an eval switch, we might need explicit conversions of the tag store, as it was not known in the surrounding environmen

Re: Threading Problem with Nashorn

2013-07-09 Thread Jim Laskey (Oracle)
That said, we are planning to support multiple threads using a worker model (post-JDK8.) The underlying mechanism used to implement workers is shipping with JDK8 (loadWithNewGlobal), so it will be possible to implement a similar model yourself. You can run the following with 'jjs -scripting':

hg: nashorn/jdk8/nashorn: 8009758: reactivate the 8006529 test.

2013-07-09 Thread attila . szegedi
Changeset: d3f4e5dea634 Author:attila Date: 2013-07-09 13:57 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/d3f4e5dea634 8009758: reactivate the 8006529 test. Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codege

hg: nashorn/jdk8/nashorn: 8014785: Ability to extend global instance by binding properties of another object

2013-07-09 Thread sundararajan . athijegannathan
Changeset: 7538a59ca241 Author:sundar Date: 2013-07-09 17:37 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/7538a59ca241 8014785: Ability to extend global instance by binding properties of another object Reviewed-by: attila, hannesw, jlaskey, lagergren ! src/jdk/na

Re: Review request for JDK-8009758

2013-07-09 Thread A. Sundararajan
+1 On Tuesday 09 July 2013 05:03 PM, Attila Szegedi wrote: Please review JDK-8009758 at http://cr.openjdk.java.net/~attila/8009758/webrev.00 Thanks, Attila.

Re: Review request for 8014785: Ability to extend global instance by binding properties of another object

2013-07-09 Thread Jim Laskey (Oracle)
+1 On 2013-07-09, at 3:53 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8014785/ > > -Sundar

Re: Review request for 8014785: Ability to extend global instance by binding properties of another object

2013-07-09 Thread A. Sundararajan
Updated webrev. Please review. -Sundar On Tuesday 09 July 2013 02:38 PM, A. Sundararajan wrote: Please ignore this webrev. There is java.beans dependency and I am going to remove it. Will post another webrev send request again. -Sundar On Tuesday 09 July 2013 12:23 PM, A. Sundararajan wrote

Review request for JDK-8009758

2013-07-09 Thread Attila Szegedi
Please review JDK-8009758 at http://cr.openjdk.java.net/~attila/8009758/webrev.00 Thanks, Attila.

Re: Threading Problem with Nashorn

2013-07-09 Thread Attila Szegedi
Hi, thanks for experimenting with Nashorn! As far as your example is concerned, Nashorn is not thread safe by design. Indeed, if you evaluate new NashornScriptEngineFactory().getParameter("THREADING") it'll return null, which means "the engine implementation is not thread safe, and c

Review request for JDK-8016681: regex capture behaves differently than on V8

2013-07-09 Thread Hannes Wallnoefer
Please review JDK-8016681: regex capture behaves differently than on V8: http://cr.openjdk.java.net/~hannesw/8016681/ Thanks, Hannes

Re: Review request for 8014785: Ability to extend global instance by binding properties of another object

2013-07-09 Thread A. Sundararajan
Please ignore this webrev. There is java.beans dependency and I am going to remove it. Will post another webrev send request again. -Sundar On Tuesday 09 July 2013 12:23 PM, A. Sundararajan wrote: Please review http://cr.openjdk.java.net/~sundar/8014785/ -Sundar

Threading Problem with Nashorn

2013-07-09 Thread Tobias Schlottke
Hi there, we're currently planning to switch our infrastructure from Rhino to Nashorn but are experiencing some threading Issues that nobody addressed so far. I tweeted with Jim Laskey and he kindly asked me to post it to this list. Example: https://gist.github.com/tobsch/5955518 Could could