hg: nashorn/jdk8/nashorn: 8020463: Input argument array wrapping in loadWithNewGlobal is wrong

2013-07-12 Thread sundararajan . athijegannathan
Changeset: 5cdf4352ee0b Author:sundar Date: 2013-07-12 20:06 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/5cdf4352ee0b 8020463: Input argument array wrapping in loadWithNewGlobal is wrong Reviewed-by: attila, jlaskey ! src/jdk/nashorn/api/scripting/ScriptObjectMir

Re: Review request for 8020463: Input argument array wrapping in loadWithNewGlobal is wrong

2013-07-12 Thread Jim Laskey (Oracle)
+1 On 2013-07-12, at 11:12 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8020463/ > > -Sundar

Review request for 8020463: Input argument array wrapping in loadWithNewGlobal is wrong

2013-07-12 Thread A. Sundararajan
Please review http://cr.openjdk.java.net/~sundar/8020463/ -Sundar

hg: nashorn/jdk8/nashorn: 8020223: ClassCastException: String can not be casted to ScriptFunction

2013-07-12 Thread sundararajan . athijegannathan
Changeset: 1a6b1799f533 Author:sundar Date: 2013-07-12 15:27 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/1a6b1799f533 8020223: ClassCastException: String can not be casted to ScriptFunction Reviewed-by: attila, lagergren ! src/jdk/nashorn/internal/objects/NativeJ

Re: Review request for 8020223: ClassCastException: String can not be casted to ScriptFunction

2013-07-12 Thread Jim Laskey (Oracle)
+1 On 2013-07-12, at 6:19 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8020223/ > > -Sundar

Re: Review request for 8020437: Wrong handling of line numbers with multiline string literals

2013-07-12 Thread Jim Laskey (Oracle)
+1 nit: Lexer.java 1462 // keep line number updated 1463 int lastLine = line; 1464 int lastLinePosition = linePosition; 1465 1466 skipLine(false); 1467 lastLine++; 1468 lastLinePosition = position; should be 1462

Re: Review request for 7187144: JavaDoc for ScriptEngineFactory.getProgram() contains an error

2013-07-12 Thread Mandy Chung
Looks good to me. Mandy On 7/11/2013 8:13 PM, A. Sundararajan wrote: Bug: http://bugs.sun.com/view_bug.do?bug_id=7187144 Please review http://cr.openjdk.java.net/~sundar/7187144/ Thanks -Sundar

hg: nashorn/jdk8/nashorn: 8019822: Duplicate name and signature in finally block

2013-07-12 Thread attila . szegedi
Changeset: e27ebcfed6fa Author:attila Date: 2013-07-12 11:58 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/e27ebcfed6fa 8019822: Duplicate name and signature in finally block Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + test/

hg: nashorn/jdk8/nashorn: 8020437: Wrong handling of line numbers with multiline string literals

2013-07-12 Thread sundararajan . athijegannathan
Changeset: d763da247244 Author:sundar Date: 2013-07-12 15:01 +0530 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/d763da247244 8020437: Wrong handling of line numbers with multiline string literals Reviewed-by: attila, lagergren ! src/jdk/nashorn/internal/parser/Lexer.jav

Review request for 8020223: ClassCastException: String can not be casted to ScriptFunction

2013-07-12 Thread A. Sundararajan
Please review http://cr.openjdk.java.net/~sundar/8020223/ -Sundar

Re: Review request for JDK-8019822

2013-07-12 Thread A. Sundararajan
+1 On Friday 12 July 2013 03:04 AM, Attila Szegedi wrote: Please review JDK-8019822 at http://cr.openjdk.java.net/~attila/8019822/webrev.00 Thanks, Attila.

Review request for 8020437: Wrong handling of line numbers with multiline string literals

2013-07-12 Thread A. Sundararajan
Please review http://cr.openjdk.java.net/~sundar/8020437 -Sundar