hg: nashorn/jdk8/nashorn: 8017585: Exclude two failing tests from Nashorn CC run

Changeset: e1d19f9fd5a9 Author:jlaskey Date: 2013-07-16 17:40 -0300 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/e1d19f9fd5a9 8017585: Exclude two failing tests from Nashorn CC run Reviewed-by: jlaskey, sundar, attila Contributed-by: konstantin.she...@oracle.com + exclu

Re: [nashorn] Review request for CR 8017585 Exclude two failing tests from Nashorn CC run

I'll push it. On 2013-07-16, at 5:20 PM, Konstantin Shefov wrote: > Will it be OK if I push the fix to > http://hg.openjdk.java.net/jdk8/awt/nashorn? > I cannot push to http://hg.openjdk.java.net/nashorn/jdk8/nashorn. > So may be it would be better if you push it. > > Thanks, > Konstantin >

Re: [nashorn] Review request for CR 8017585 Exclude two failing tests from Nashorn CC run

Will it be OK if I push the fix to http://hg.openjdk.java.net/jdk8/awt/nashorn? I cannot push to http://hg.openjdk.java.net/nashorn/jdk8/nashorn. So may be it would be better if you push it. Thanks, Konstantin 16.07.2013 20:22, Jim Laskey (Oracle) пишет: +1 Thank you. On 2013-07-16, at 1:03 P

Re: [nashorn] Review request for CR 8017585 Exclude two failing tests from Nashorn CC run

+1 Thank you. On 2013-07-16, at 1:03 PM, Konstantin Shefov wrote: > Please, review the two exception list solution: > > http://cr.openjdk.java.net/~kshefov/8017585/webrev.01/ > > > 16.07.2013 16:13, Konstantin Shefov пишет: >> I will

Re: [nashorn] Review request for CR 8017585 Exclude two failing tests from Nashorn CC run

Please, review the two exception list solution: http://cr.openjdk.java.net/~kshefov/8017585/webrev.01/ 16.07.2013 16:13, Konstantin Shefov пишет: I will try to implement this. On 16-Jul-13 16:11, Jim Laskey (Oracle) wrote: We still

Re: [nashorn] Review request for CR 8017585 Exclude two failing tests from Nashorn CC run

Looks good to me; +1 On Jul 16, 2013, at 6:03 PM, Konstantin Shefov wrote: > Please, review the two exception list solution: > > http://cr.openjdk.java.net/~kshefov/8017585/webrev.01/ > > > 16.07.2013 16:13, Konstantin Shefov пишет:

Re: [nashorn] Review request for CR 8017585 Exclude two failing tests from Nashorn CC run

+1 On Tuesday 16 July 2013 09:33 PM, Konstantin Shefov wrote: Please, review the two exception list solution: http://cr.openjdk.java.net/~kshefov/8017585/webrev.01/ 16.07.2013 16:13, Konstantin Shefov пишет: I will try to implement

hg: nashorn/jdk8/nashorn: 8015356: array concatenation should skip empty elements

Changeset: 78bdb8a7f1e7 Author:attila Date: 2013-07-16 17:03 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/78bdb8a7f1e7 8015356: array concatenation should skip empty elements Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/objects/NativeArray.java + test/s

Re: Review request for JDK-8015356

+1 On 2013-07-16, at 11:46 AM, Attila Szegedi wrote: > Please review JDK-8015356 at > http://cr.openjdk.java.net/~attila/8015356/webrev.00 > > Thanks, > Attila.

Review request for JDK-8015356

Please review JDK-8015356 at http://cr.openjdk.java.net/~attila/8015356/webrev.00 Thanks, Attila.

hg: nashorn/jdk8/nashorn: 8010821: [findbugs] Some classes in jdk.nashorn.internal.runtime.regexp expose mutable objects

Changeset: 7503f30c1355 Author:hannesw Date: 2013-07-16 16:12 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/7503f30c1355 8010821: [findbugs] Some classes in jdk.nashorn.internal.runtime.regexp expose mutable objects Reviewed-by: attila, jlaskey, sundar ! src/jdk/n

hg: nashorn/jdk8/langtools: 111 new changesets

Changeset: d685b12b62a4 Author:jjg Date: 2013-05-29 15:34 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/langtools/rev/d685b12b62a4 8015641: genstubs needs to cope with static interface methods Reviewed-by: ksrini ! make/tools/genstubs/GenStubs.java Changeset: 9f11c7676cd5 Aut

hg: nashorn/jdk8/nashorn: 8020357: throw RangeError for too large NativeArrayBuffer size

Changeset: 965d876853ec Author:attila Date: 2013-07-16 15:28 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/965d876853ec 8020357: throw RangeError for too large NativeArrayBuffer size Reviewed-by: jlaskey, hannesw, sundar ! src/jdk/nashorn/internal/objects/ArrayBuff

Re: Review request for JDK-8010821

+1 On 2013-07-16, at 10:20 AM, Hannes Wallnoefer wrote: > Please review JDK-8010821: [findbugs] Some classes in > jdk.nashorn.internal.runtime.regexp expose mutable objects: > > http://cr.openjdk.java.net/~hannesw/8010821/ > > Thanks, > Hannes

Re: Review request for JDK-8010821

+1 On Tuesday 16 July 2013 06:50 PM, Hannes Wallnoefer wrote: Please review JDK-8010821: [findbugs] Some classes in jdk.nashorn.internal.runtime.regexp expose mutable objects: http://cr.openjdk.java.net/~hannesw/8010821/ Thanks, Hannes

Re: Review request for JDK-8010821

+1 On Jul 16, 2013, at 3:20 PM, Hannes Wallnoefer wrote: > Please review JDK-8010821: [findbugs] Some classes in > jdk.nashorn.internal.runtime.regexp expose mutable objects: > > http://cr.openjdk.java.net/~hannesw/8010821/ > > Thanks, > Hannes

Review request for JDK-8010821

Please review JDK-8010821: [findbugs] Some classes in jdk.nashorn.internal.runtime.regexp expose mutable objects: http://cr.openjdk.java.net/~hannesw/8010821/ Thanks, Hannes

hg: nashorn/jdk8: 36 new changesets

Changeset: 33b6df33a2b7 Author:erikj Date: 2013-05-29 13:58 +0200 URL: http://hg.openjdk.java.net/nashorn/jdk8/rev/33b6df33a2b7 8013920: Configure sets JOBS to 0 if memory is too low. Reviewed-by: tbell ! common/autoconf/build-performance.m4 ! common/autoconf/generated-configure.sh

hg: nashorn/jdk8/jaxws: 10 new changesets

Changeset: a0f604766ca1 Author:katleman Date: 2013-05-23 10:47 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxws/rev/a0f604766ca1 Added tag jdk8-b91 for changeset 0bb1a9fa56b0 ! .hgtags Changeset: 7386eca865e1 Author:katleman Date: 2013-05-30 10:58 -0700 URL:

hg: nashorn/jdk8/jaxp: 37 new changesets

Changeset: 827b59af45f3 Author:katleman Date: 2013-05-23 10:47 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/jaxp/rev/827b59af45f3 Added tag jdk8-b91 for changeset e3065fb07877 ! .hgtags Changeset: 1ab5d8d6eab8 Author:katleman Date: 2013-05-29 10:15 -0700 URL:

Re: [nashorn] Review request for CR 8017585 Exclude two failing tests from Nashorn CC run

I will try to implement this. On 16-Jul-13 16:11, Jim Laskey (Oracle) wrote: We still expect a two exception list solution at some point. On 2013-07-16, at 8:50 AM, A. Sundararajan wrote: And please make sure "ant clean test" and "ant clean test262parallel" are fine with your change before

hg: nashorn/jdk8/corba: 20 new changesets

Changeset: 717aa26f8e0a Author:katleman Date: 2013-05-23 10:47 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/corba/rev/717aa26f8e0a Added tag jdk8-b91 for changeset 8f7ffb296385 ! .hgtags Changeset: 8dc9d7ccbb2d Author:katleman Date: 2013-05-30 10:57 -0700 URL:

Re: [nashorn] Review request for CR 8017585 Exclude two failing tests from Nashorn CC run

We still expect a two exception list solution at some point. On 2013-07-16, at 8:50 AM, A. Sundararajan wrote: > And please make sure "ant clean test" and "ant clean test262parallel" are > fine with your change before pushing the change. > > -Sundar > > On Tuesday 16 July 2013 04:33 PM, Jim

Re: [nashorn] Review request for CR 8017585 Exclude two failing tests from Nashorn CC run

And please make sure "ant clean test" and "ant clean test262parallel" are fine with your change before pushing the change. -Sundar On Tuesday 16 July 2013 04:33 PM, Jim Laskey (Oracle) wrote: We had a discussion about whether this was the best approach. I think we had been thinking in terms

hg: nashorn/jdk8/nashorn: 38 new changesets

Changeset: dee23cce5235 Author:katleman Date: 2013-05-23 10:47 -0700 URL: http://hg.openjdk.java.net/nashorn/jdk8/nashorn/rev/dee23cce5235 Added tag jdk8-b91 for changeset 6b9f41203800 ! .hgtags Changeset: 1c7481ac7fe0 Author:katleman Date: 2013-05-30 10:58 -0700 URL:

Re: [nashorn] Review request for CR 8017585 Exclude two failing tests from Nashorn CC run

We had a discussion about whether this was the best approach. I think we had been thinking in terms of two separate exclude lists. In lieu of a better solution. go a head with this change. Cheers, -- Jim On 2013-07-16, at 7:33 AM, Konstantin Shefov wrote: > REMINDER > On 11-Jul-13 14:41

Re: [nashorn] Review request for CR 8017585 Exclude two failing tests from Nashorn CC run

REMINDER On 11-Jul-13 14:41, Konstantin Shefov wrote: Hello, Please review a fix for the issue: 8017585 Exclude two failing tests from Nashorn CC run http://bugs.sun.com/view_bug.do?bug_id=8017585 The webrev is: http://cr.openjdk.java.net/~kshefov/8017585/webrev.00 Thanks, Konstantin