Re: Review request for JDK-8026955: for-in should convert primitive values to object

2013-10-21 Thread Hannes Wallnoefer
Looks like the zip file was too big. Trying again with just the patch file. Hannes Am 2013-10-21 18:34, schrieb Hannes Wallnoefer: Please review JDK-8026955: for-in should convert primitive values to object. webrev zip is attached because of problems with cr.openjdk.java.net. Thanks, Hannes

Review request for JDK-8026955: for-in should convert primitive values to object

2013-10-21 Thread Hannes Wallnoefer
Please review JDK-8026955: for-in should convert primitive values to object. webrev zip is attached because of problems with cr.openjdk.java.net. Thanks, Hannes

Side effects of RHS in BinaryNode

2013-10-21 Thread Hannes Wallnoefer
I thought about this again this morning and I think your version is actually not correct. It's not enough to make sure the AST leaves are side effects free because operator nodes may trigger conversion to JS primitives which may have side effects of its own. E.g. in "-x", the minus unary ope