Re: RFR JDK-8015958: DataView constructor is not defined

2014-03-13 Thread Marcus Lagergren
Looks good. +1 We should fast link the setters and getters in the performance release, but that’s a separate enhancement (see findFastGetIndexMethod and findFastSetIndexMethod in the perf repo) /M On 13 Mar 2014, at 07:58, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~su

Re: RFR JDK-8015958: DataView constructor is not defined

2014-03-13 Thread Hannes Wallnoefer
+1 Am 2014-03-13 07:58, schrieb A. Sundararajan: Please review http://cr.openjdk.java.net/~sundar/8015958/ Bug: https://bugs.openjdk.java.net/browse/JDK-8015958 Thanks -Sundar

Re: Review request for JDK-8034055: delete on global object not properly guarded

2014-03-13 Thread Attila Szegedi
+1 On Mar 12, 2014, at 3:14 PM, Hannes Wallnoefer wrote: > Please review JDK-8034055: delete on global object not properly guarded: > > http://cr.openjdk.java.net/~hannesw/8034055/ > > This only adds a test case as the bug was fixed in my previous commit > (JDK-8021350: Share script classes

Re: RFR JDK-8015958: DataView constructor is not defined

2014-03-13 Thread Attila Szegedi
Looks good, +1 On Mar 13, 2014, at 7:58 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8015958/ > Bug: https://bugs.openjdk.java.net/browse/JDK-8015958 > > Thanks > -Sundar

Re: Review request for JDK-8034055: delete on global object not properly guarded

2014-03-13 Thread Marcus Lagergren
+1 On 12 Mar 2014, at 15:14, Hannes Wallnoefer wrote: > Please review JDK-8034055: delete on global object not properly guarded: > > http://cr.openjdk.java.net/~hannesw/8034055/ > > This only adds a test case as the bug was fixed in my previous commit > (JDK-8021350: Share script classes bet