Re: RFR 8042600: Add more samples in nashorn/samples directory

2014-05-07 Thread A. Sundararajan
Thanks. Fixed semicolons in http://cr.openjdk.java.net/~sundar/8042600/webrev.01/ -Sundar On Wednesday 07 May 2014 07:23 PM, Hannes Wallnoefer wrote: I would prefer having semicolons after statements, I think it's the more widely accepted form. Otherwise looks very good! Hannes Am 2014-05-

Re: RFR 8042600: Add more samples in nashorn/samples directory

2014-05-07 Thread Hannes Wallnoefer
I would prefer having semicolons after statements, I think it's the more widely accepted form. Otherwise looks very good! Hannes Am 2014-05-07 15:17, schrieb A. Sundararajan: Please review http://cr.openjdk.java.net/~sundar/8042600/ Bug: https://bugs.openjdk.java.net/browse/JDK-8042600 Thank

Re: RFR 8042600: Add more samples in nashorn/samples directory

2014-05-07 Thread Jim Laskey (Oracle)
+1 On May 7, 2014, at 10:17 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8042600/ > Bug: https://bugs.openjdk.java.net/browse/JDK-8042600 > > Thanks, > -Sundar

RFR 8042600: Add more samples in nashorn/samples directory

2014-05-07 Thread A. Sundararajan
Please review http://cr.openjdk.java.net/~sundar/8042600/ Bug: https://bugs.openjdk.java.net/browse/JDK-8042600 Thanks, -Sundar

Re: RFR 8041697: CompiledScript slower when eval with binding

2014-05-07 Thread Hannes Wallnoefer
+1 Am 2014-05-07 10:15, schrieb A. Sundararajan: Please review http://cr.openjdk.java.net/~sundar/8041697/ Bug: https://bugs.openjdk.java.net/browse/JDK-8041697 Related to http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-April/002920.html Thanks, -Sundar

Re: RFR 8041697: CompiledScript slower when eval with binding

2014-05-07 Thread Attila Szegedi
+1 On May 7, 2014, at 10:15 AM, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8041697/ > Bug: https://bugs.openjdk.java.net/browse/JDK-8041697 > > Related to > http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-April/002920.html > > Thanks, > -Sundar

RFR 8041697: CompiledScript slower when eval with binding

2014-05-07 Thread A. Sundararajan
Please review http://cr.openjdk.java.net/~sundar/8041697/ Bug: https://bugs.openjdk.java.net/browse/JDK-8041697 Related to http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-April/002920.html Thanks, -Sundar