Re: Review request for JDK-8043956: Make code caching work with optimistic typing and lazy compilation

2014-08-04 Thread Hannes Wallnoefer
Hi Marcus, answers inline. Am 2014-08-04 um 18:20 schrieb Marcus Lagergren: Hi Hannes! I get the general gist of this and it looks nice. Some questions though, which I probably ask because I am sunstruck by the 33 C in my house. I don’t understand all parts of the change, but I do understand

Re: Review request for JDK-8043956: Make code caching work with optimistic typing and lazy compilation

2014-08-04 Thread Marcus Lagergren
Hi Hannes! I get the general gist of this and it looks nice. Some questions though, which I probably ask because I am sunstruck by the 33 C in my house. I don’t understand all parts of the change, but I do understand it architecturally fine. No particular priority or size order of questions belo

Re: RFR 8054223: Nashorn: AssertionError when use __DIR__ and ScriptEngine.eval()

2014-08-04 Thread Hannes Wallnoefer
Looks good. Hannes Am 2014-08-04 um 17:53 schrieb A. Sundararajan: Please review http://cr.openjdk.java.net/~sundar/8054223/ -Sundar

Re: RFR 8054223: Nashorn: AssertionError when use __DIR__ and ScriptEngine.eval()

2014-08-04 Thread Marcus Lagergren
+1 On 04 Aug 2014, at 17:53, A. Sundararajan wrote: > Please review http://cr.openjdk.java.net/~sundar/8054223/ > > -Sundar

RFR 8054223: Nashorn: AssertionError when use __DIR__ and ScriptEngine.eval()

2014-08-04 Thread A. Sundararajan
Please review http://cr.openjdk.java.net/~sundar/8054223/ -Sundar

Review request for JDK-8043956: Make code caching work with optimistic typing and lazy compilation

2014-08-04 Thread Hannes Wallnoefer
Please review JDK-8043956: Make code caching work with optimistic typing and lazy compilation: http://cr.openjdk.java.net/~hannesw/8043956/webrev.01/ Thanks, Hannes

Re: Nashorn Roadmap & Rhino migration question

2014-08-04 Thread A. Sundararajan
Hi, Nashorn engine picks up thread-context loader at the time of engine creation or user supplied loader (with nashorn specific extension API). For the cases like you specify, you've to use reflection - but only to get to the class. Something like // get java.lang.Class object of the desire

Re: Nashorn Roadmap & Rhino migration question

2014-08-04 Thread Paul Bakker
Hi, Tnx for the clarifications. @sundar: I realise that I didn't properly clarify my question. What we do in Rhino is load classes using a custom classloader inside scripting. like this: try { var cx = Packages.org.mozilla.javascript.Context.getCurrentContext() var saved