Re: Review request for JDK-8067219: NPE in ScriptObject.clone() when running with object fields

Good simple fix! +1 > On 11 Dec 2014, at 19:12, Hannes Wallnoefer > wrote: > > Please review JDK-8067219: NPE in ScriptObject.clone() when running with > object fields: > > http://cr.openjdk.java.net/~hannesw/8067219/ > > Thanks, > Hannes

Re: Review request for JDK-8066669: dust.js performance regression caused by primitive field conversion

+1 on backport > On 11 Dec 2014, at 16:48, Attila Szegedi wrote: > > +1 on backport > > On Dec 11, 2014, at 4:00 PM, Hannes Wallnoefer > wrote: > >> Backport patch to 8u40 failed in two places in MethodEmitter.java because >> the beginning of dynamicGet and dynamicSet methods changed in 9.

Re: Review request for JDK-8067219: NPE in ScriptObject.clone() when running with object fields

+1. Nice catch. On Dec 11, 2014, at 7:12 PM, Hannes Wallnoefer wrote: > Please review JDK-8067219: NPE in ScriptObject.clone() when running with > object fields: > > http://cr.openjdk.java.net/~hannesw/8067219/ > > Thanks, > Hannes

Review request for JDK-8067219: NPE in ScriptObject.clone() when running with object fields

Please review JDK-8067219: NPE in ScriptObject.clone() when running with object fields: http://cr.openjdk.java.net/~hannesw/8067219/ Thanks, Hannes

Re: Review request for JDK-8066669: dust.js performance regression caused by primitive field conversion

+1 on backport On Dec 11, 2014, at 4:00 PM, Hannes Wallnoefer wrote: > Backport patch to 8u40 failed in two places in MethodEmitter.java because the > beginning of dynamicGet and dynamicSet methods changed in 9. > > Please review backport to 8u here: > http://cr.openjdk.java.net/~hannesw/806

Re: Review request for JDK-8066669: dust.js performance regression caused by primitive field conversion

Backport patch to 8u40 failed in two places in MethodEmitter.java because the beginning of dynamicGet and dynamicSet methods changed in 9. Please review backport to 8u here: http://cr.openjdk.java.net/~hannesw/809/ Thanks, Hannes Am 2014-12-11 um 14:47 schrieb Hannes Wallnoefer: I upload

Re: Review request for JDK-8066669: dust.js performance regression caused by primitive field conversion

+1 On Thursday 11 December 2014 07:17 PM, Hannes Wallnoefer wrote: I uploaded a new webrev that only replaces index nodes with string index expressions as suggested by Attila, and added tests for index operations on a java HashMap. Please review. http://cr.openjdk.java.net/~hannesw/809/

Re: Review request for JDK-8066669: dust.js performance regression caused by primitive field conversion

+1 on the .01 webrev. On Dec 11, 2014, at 2:47 PM, Hannes Wallnoefer wrote: > I uploaded a new webrev that only replaces index nodes with string index > expressions as suggested by Attila, and added tests for index operations on a > java HashMap. Please review. > > http://cr.openjdk.java.net

Re: Review request for JDK-8066669: dust.js performance regression caused by primitive field conversion

I uploaded a new webrev that only replaces index nodes with string index expressions as suggested by Attila, and added tests for index operations on a java HashMap. Please review. http://cr.openjdk.java.net/~hannesw/809/ Thanks, Hannes Am 2014-12-11 um 13:48 schrieb Hannes Wallnoefer: Ple

Review request for JDK-8066669: dust.js performance regression caused by primitive field conversion

Please review JDK-809: dust.js performance regression caused by primitive field conversion: http://cr.openjdk.java.net/~hannesw/809/ Thanks, Hannes

Re: Review request for JDK-8066932: __noSuchMethod__ binds to this-object without proper guard

+1 > On 11 Dec 2014, at 11:45, Hannes Wallnoefer > wrote: > > Please review JDK-8066932: __noSuchMethod__ binds to this-object without > proper guard: > > http://cr.openjdk.java.net/~hannesw/8066932/ > > Thanks, > Hannes

Re: Review request for JDK-8066932: __noSuchMethod__ binds to this-object without proper guard

+1 On Dec 11, 2014, at 11:45 AM, Hannes Wallnoefer wrote: > Please review JDK-8066932: __noSuchMethod__ binds to this-object without > proper guard: > > http://cr.openjdk.java.net/~hannesw/8066932/ > > Thanks, > Hannes

Review request for JDK-8066932: __noSuchMethod__ binds to this-object without proper guard

Please review JDK-8066932: __noSuchMethod__ binds to this-object without proper guard: http://cr.openjdk.java.net/~hannesw/8066932/ Thanks, Hannes

Re: Review request for JDK-8066221

+1 for the backport. Am 2014-12-10 um 18:43 schrieb Attila Szegedi: Thanks for the reviews folks. Unfortunately, since this change concerns the parser, I need a separate review for 8u backport at The difference is around the