Re: RFR 8150731: Nashorn JSObject linker should be exposed as a service provider

2016-03-10 Thread Attila Szegedi
+1 > On Mar 10, 2016, at 10:06 AM, Sundararajan Athijegannathan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8150731/webrev.01/ for > https://bugs.openjdk.java.net/browse/JDK-8150731 > > Thanks, > -Sundar

Re: RFR 8150731: Nashorn JSObject linker should be exposed as a service provider

2016-03-10 Thread Michael Haupt
Hi Sundar, lower-case thumbs up, with one remark about the test. It seems the lower part of the test method is independent of the upper part; separate aspects should IMHO be tested separetely, i.e., in two different methods. Best, Michael > Am 10.03.2016 um 10:06 schrieb Sundararajan Athijega

RFR 8150731: Nashorn JSObject linker should be exposed as a service provider

2016-03-10 Thread Sundararajan Athijegannathan
Please review http://cr.openjdk.java.net/~sundar/8150731/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8150731 Thanks, -Sundar