Re: [PATCH] javax,script.ScriptEngineFactory Typos

2015-07-14 Thread Ahmed Ashour
Sent: Tuesday, July 14, 2015 12:38 PM Subject: Re: Fwd: Re: [PATCH] javax,script.ScriptEngineFactory Typos Hi Ahmed, Did you build the forest with that change or just "found" by code reading? Because {@code requires } to end it. So, those were not 'extra' '}' c

Re: Fwd: Re: [PATCH] javax,script.ScriptEngineFactory Typos

2015-07-14 Thread A. Sundararajan
ribution from Ahmed to core-libs-dev alias as the change is going to be in "jdk/java.scripting/javax.script" code. PS. I'll send out webrev after build, test. Thanks Ahmed, -Sundar ---- Forwarded Message ---- Subject: Re: [PATCH] javax,script.ScriptEngineFactory Typ

Re: [PATCH] javax,script.ScriptEngineFactory Typos

2015-07-09 Thread Ahmed Ashour
Dear all, Please find below a proposed patch based on jdk9/dev. Thanks, Ahmed diff -r b526c2584b4b src/java.scripting/share/classes/javax/script/ScriptEngineFactory.java --- a/src/java.scripting/share/classes/javax/script/ScriptEngineFactory.java Wed Jul 08 21:54:32 2015 -0400 +++ b/src/ja

Re: [PATCH] javax,script.ScriptEngineFactory Typos

2015-07-08 Thread Ahmed Ashour
Dear all, Please find below, hope it is fine. Thanks,Ahmed diff -r b526c2584b4b src/java.scripting/share/classes/javax/script/ScriptEngineFactory.java--- a/src/java.scripting/share/classes/javax/script/ScriptEngineFactory.java    Wed Jul 08 21:54:32 2015 -0400+++ b/src/java.scripting/share/cla

Re: [PATCH] javax,script.ScriptEngineFactory Typos

2015-07-08 Thread A. Sundararajan
Hi, Will you please send output of "hg diff" cut pasted as body text in email? regards, -Sundar On Tuesday 07 July 2015 02:35 PM, Ahmed Ashour wrote: Hi all, Please find below a proposed patch for the typos in javax.script.ScriptEngineFactory Thanks,Ahmed diff --git a/src/java.scripting/sha

[PATCH] javax,script.ScriptEngineFactory Typos

2015-07-07 Thread Ahmed Ashour
Hi all, Please find below a proposed patch for the typos in  javax.script.ScriptEngineFactory Thanks,Ahmed diff --git a/src/java.scripting/share/classes/javax/script/ScriptEngineFactory.java b/src/java.scripting/share/classes/javax/script/ScriptEngineFactory.java--- a/src/java.scripting/share/