Re: RFR 8027137: Merge ScriptFunction and ScriptFunctionImpl

2015-09-11 Thread Marcus Lagergren
I love this change! Thanks for it! /M > On 09 Sep 2015, at 13:39, Hannes Wallnoefer > wrote: > > Looks good! > > Am 2015-09-09 um 13:22 schrieb Sundararajan Athijegannathan: >> Thanks for the reviews Hannes & Attila. >> >> I've incorporated the changes suggested. Updated webrev: >> http://c

Re: RFR 8027137: Merge ScriptFunction and ScriptFunctionImpl

2015-09-09 Thread Hannes Wallnoefer
Looks good! Am 2015-09-09 um 13:22 schrieb Sundararajan Athijegannathan: Thanks for the reviews Hannes & Attila. I've incorporated the changes suggested. Updated webrev: http://cr.openjdk.java.net/~sundar/8027137/webrev.01/ PS. I've changed all counters (used from NativeDebug) to use LongAdd

Re: RFR 8027137: Merge ScriptFunction and ScriptFunctionImpl

2015-09-09 Thread Attila Szegedi
Excellent, +1. > On Sep 9, 2015, at 1:22 PM, Sundararajan Athijegannathan > wrote: > > Thanks for the reviews Hannes & Attila. > > I've incorporated the changes suggested. Updated webrev: > http://cr.openjdk.java.net/~sundar/8027137/webrev.01/ > > PS. I've changed all counters (used from Nat

Re: RFR 8027137: Merge ScriptFunction and ScriptFunctionImpl

2015-09-09 Thread Sundararajan Athijegannathan
Thanks for the reviews Hannes & Attila. I've incorporated the changes suggested. Updated webrev: http://cr.openjdk.java.net/~sundar/8027137/webrev.01/ PS. I've changed all counters (used from NativeDebug) to use LongAdder. -Sundar On 9/9/2015 2:57 PM, Attila Szegedi wrote: Great work! I’m v

Re: RFR 8027137: Merge ScriptFunction and ScriptFunctionImpl

2015-09-09 Thread Attila Szegedi
Great work! I’m very happy that ScriptFunctionImpl is going away. Some implementation remarks: - The newly public methods in Global.java, getFunctionPrototype and getTypeErrorThrower don’t have Javadoc. - The newly public two constructors of PrototypeObject also don’t hava Javadoc. - while you'

Re: RFR 8027137: Merge ScriptFunction and ScriptFunctionImpl

2015-09-09 Thread Hannes Wallnoefer
The javadoc comment in ScriptFunctionData#makeBoundFunctionData refers to {@link ScriptFunction#makeBoundFunction(Object, Object[])} which is now called createBound. Apart than that +1. Nice! Hannes Am 2015-09-09 um 10:19 schrieb Sundararajan Athijegannathan: Please review http://cr.openjdk.

Re: RFR 8027137: Merge ScriptFunction and ScriptFunctionImpl

2015-09-09 Thread Michael Haupt
Hi Sundar, lower-case thumbs up! Best, Michael > Am 09.09.2015 um 10:19 schrieb Sundararajan Athijegannathan > : > > Please review http://cr.openjdk.java.net/~sundar/8027137/ for > https://bugs.openjdk.java.net/browse/JDK-8027137 > > Thanks, > -Sundar -- Dr. Mic