Re: Review request for JDK-8139590: Improve Dynalink JavaDoc

2015-10-16 Thread Hannes Wallnoefer
Looks good. A few minor issues I found: - GuardedInvocation.java class javadoc: "as long as the switch point is not invalidated" should be plural. - LinkRequest.java #getReceiver: I think "first argument" would be more intuitive than "0th argument". - BeansLinker.java class javadoc last sentenc

Re: Review request for JDK-8139590: Improve Dynalink JavaDoc

2015-10-16 Thread Marcus Lagergren
+1 > On 14 Oct 2015, at 15:48, Attila Szegedi wrote: > > Please review JDK-8139590 "Improve Dynalink JavaDoc" at > for > > > Notes: > - webrev also shows some previous issues in the his

Review request for JDK-8139590: Improve Dynalink JavaDoc

2015-10-14 Thread Attila Szegedi
Please review JDK-8139590 "Improve Dynalink JavaDoc" at for Notes: - webrev also shows some previous issues in the history of some of the files, but the changes for those issue are not in