Re: [Nbd] [PATCH v3 1/2] doc: Use dedicated reply types for NBD_OPT_INFO/GO

Hi Eric, On Wed, Apr 13, 2016 at 06:37:29PM -0600, Eric Blake wrote: > Since NBD_OPT_INFO and NBD_OPT_GO are experimental, we still have > a chance to fix them up before promoting them to stable. > > Attempting to reuse NBD_OPT_SERVER as the reply to NBD_OPT_INFO and > NBD_OPT_GO has a few proble

Re: [Nbd] [PATCHv7] docs/proto.md: Clarify SHOULD / MUST / MAY etc

On 13 Apr 2016, at 22:33, Eric Blake wrote: > On 04/12/2016 12:35 PM, Alex Bligh wrote: >> These are changes which possibly have semantic effect >> >> * Clarify that SHOULD / MUST / MAY etc. when in capitals have an >> RFC 2119 meaning using the wording within that RFC. >> >> * Fix some lower

Re: [Nbd] [PATCH v3 1/2] doc: Use dedicated reply types for NBD_OPT_INFO/GO

Eric, > +Both options have identical formats for requests and replies. The only > +difference is that after a successful reply to `NBD_OPT_GO` (i.e. zero > +or more `NBD_REP_INFO` then an `NBD_REP_EXPORT`), transmission mode is > +entered immediately. Therefore these commands share common > +docu

Re: [Nbd] [PATCH v3 2/2] doc: Add details on block sizes

On 14 Apr 2016, at 01:37, Eric Blake wrote: > > +## Block sizes > + > +During transmission phase, several operations are constrained by the > +export size sent in reply to `NBD_OPT_EXPORT_NAME` or `NBD_OPT_GO` or NBD_OPT_INFO? > , as > +well as by three block sizes defined here (minimum, prefe

Re: [Nbd] [PATCH] Docs: improve description of disconnection methods

Wouter, On 14 Apr 2016, at 07:49, Wouter Verhelst wrote: > On Wed, Apr 13, 2016 at 01:21:17PM +0100, Alex Bligh wrote: >> Wouter, >> >> On 13 Apr 2016, at 12:44, Wouter Verhelst wrote: >> >>> Hi Alex, >>> >>> On Wed, Apr 13, 2016 at 11:25:02AM +0100, Alex Bligh wrote: Wouter,

Re: [Nbd] [PATCHv7] docs/proto.md: Clarify SHOULD / MUST / MAY etc

On Wed, Apr 13, 2016 at 03:33:56PM -0600, Eric Blake wrote: > Is there anything still holding this up, or can we get it applied? It's > acting as a conflict magnet for other patches that are still under > discussion. Merged it this morning, as well as Alex' "two nits" followup (but apparently forg

[Nbd] More efficient treatment of experimental protocol extensions

I have a proposal for the more efficient treatment of experimental protocol extensions. This primarily concerns doc/proto.md, but potentially affects code too. At present the experimental protocol extensions are described in 'experimental extensions' at the bottom of the document in master. This c

Re: [Nbd] [PATCHv7] docs/proto.md: Clarify SHOULD / MUST / MAY etc

On 14 Apr 2016, at 13:43, Wouter Verhelst wrote: > On Wed, Apr 13, 2016 at 03:33:56PM -0600, Eric Blake wrote: >> Is there anything still holding this up, or can we get it applied? It's >> acting as a conflict magnet for other patches that are still under >> discussion. > > Merged it this morni

Re: [Nbd] [PATCH v3 1/2] doc: Use dedicated reply types for NBD_OPT_INFO/GO

On 04/14/2016 01:25 AM, Wouter Verhelst wrote: > Hi Eric, > > On Wed, Apr 13, 2016 at 06:37:29PM -0600, Eric Blake wrote: >> Since NBD_OPT_INFO and NBD_OPT_GO are experimental, we still have >> a chance to fix them up before promoting them to stable. >> >> Attempting to reuse NBD_OPT_SERVER as the

Re: [Nbd] [PATCH v3 1/2] doc: Use dedicated reply types for NBD_OPT_INFO/GO

On 04/14/2016 04:29 AM, Alex Bligh wrote: > Eric, > >> +Both options have identical formats for requests and replies. The only >> +difference is that after a successful reply to `NBD_OPT_GO` (i.e. zero >> +or more `NBD_REP_INFO` then an `NBD_REP_EXPORT`), transmission mode is >> +entered immediate

Re: [Nbd] [PATCH v3 1/2] doc: Use dedicated reply types for NBD_OPT_INFO/GO

On 14 Apr 2016, at 14:59, Eric Blake wrote: > On 04/14/2016 04:29 AM, Alex Bligh wrote: >> Eric, >> >>> +Both options have identical formats for requests and replies. The only >>> +difference is that after a successful reply to `NBD_OPT_GO` (i.e. zero >>> +or more `NBD_REP_INFO` then an `NBD_RE

Re: [Nbd] [PATCH v3 1/2] doc: Use dedicated reply types for NBD_OPT_INFO/GO

On 04/14/2016 09:31 AM, Alex Bligh wrote: > > On 14 Apr 2016, at 14:59, Eric Blake wrote: > >> On 04/14/2016 04:29 AM, Alex Bligh wrote: >>> Eric, >>> +Both options have identical formats for requests and replies. The only +difference is that after a successful reply to `NBD_OPT_GO` (i

Re: [Nbd] More efficient treatment of experimental protocol extensions

On Thu, Apr 14, 2016 at 01:46:35PM +0100, Alex Bligh wrote: > I have a proposal for the more efficient treatment of experimental > protocol extensions. This primarily concerns doc/proto.md, but > potentially affects code too. > > At present the experimental protocol extensions are described in > '

Re: [Nbd] [PATCH v3 1/2] doc: Use dedicated reply types for NBD_OPT_INFO/GO

On 14 Apr 2016, at 16:37, Eric Blake wrote: >> >> >> And indeed a FORCETLS server can reply with NBD_REP_ERR_TLSREQD. >> > > Technically, a FORCETLS server MUST reply with NBD_REP_ERR_TLS_REQD, > without any intervening NBD_REP_INFO. Yes, indeed. > Only a SELECTIVETLS server MAY > send inte

Re: [Nbd] [PATCH] Docs: improve description of disconnection methods

On Thu, Apr 14, 2016 at 12:29:09PM +0100, Alex Bligh wrote: > Wouter, > > On 14 Apr 2016, at 07:49, Wouter Verhelst wrote: > > > On Wed, Apr 13, 2016 at 01:21:17PM +0100, Alex Bligh wrote: > >> Secondly I think you are doing exactly what I said below. You > >> are processing it immediately, but

Re: [Nbd] [PATCH v3 1/2] doc: Use dedicated reply types for NBD_OPT_INFO/GO

On Thu, Apr 14, 2016 at 04:31:00PM +0100, Alex Bligh wrote: > On 14 Apr 2016, at 14:59, Eric Blake wrote: > > Okay. And thinking about it more, a server may indeed want to advertise > > all names by which an export is known, so NBD_INFO_NAME could even be > > given more than once (but then the wor

Re: [Nbd] [PATCH v3 1/2] doc: Use dedicated reply types for NBD_OPT_INFO/GO

On Thu, Apr 14, 2016 at 09:37:52AM -0600, Eric Blake wrote: > On 04/14/2016 09:31 AM, Alex Bligh wrote: > > Mmmm ... maybe. I'm not actually quite sure what the purpose of > > sending the canonical name is, but if there is a purpose may be > > we should set a 'canonical' flag on that one. > > That

Re: [Nbd] More efficient treatment of experimental protocol extensions

Wouter, On 14 Apr 2016, at 16:38, Wouter Verhelst wrote: >> My proposal is as follows: >> >> * Experimental extensions do not appear in proto.md in master at all >> EXCEPT for reservation of codes (e.g. "NBD_OPT_FOOBAR (42) - reserved >> for experimental FOOBAR extension"). >> >> * Experimen

Re: [Nbd] [PATCH] Docs: improve description of disconnection methods

Wouter, >> There are two issues here. >> >> Firstly, I would prefer that there is at least a SHOULD NOT condition >> against sending a disconnect before the client has received replies. >> You don't agree with that, and that's fine, I'm going with your >> view (at least for the purposes of this r

Re: [Nbd] More efficient treatment of experimental protocol extensions

On Thu, Apr 14, 2016 at 05:16:28PM +0100, Alex Bligh wrote: > Wouter, > > On 14 Apr 2016, at 16:38, Wouter Verhelst wrote: > > This sounds like a viable approach, > > I propose I come up with a patch to move the current experimental > stuff out to a branch then. > > As Erik currently is perform

Re: [Nbd] [PATCH v3 2/2] doc: Add details on block sizes

On 04/14/2016 05:05 AM, Alex Bligh wrote: > > On 14 Apr 2016, at 01:37, Eric Blake wrote: >> >> +## Block sizes >> + >> +During transmission phase, several operations are constrained by the >> +export size sent in reply to `NBD_OPT_EXPORT_NAME` or `NBD_OPT_GO` > > or NBD_OPT_INFO? Not really -

Re: [Nbd] More efficient treatment of experimental protocol extensions

On 04/14/2016 10:38 AM, Wouter Verhelst wrote: > On Thu, Apr 14, 2016 at 05:16:28PM +0100, Alex Bligh wrote: >> Wouter, >> >> On 14 Apr 2016, at 16:38, Wouter Verhelst wrote: >>> This sounds like a viable approach, >> >> I propose I come up with a patch to move the current experimental >> stuff ou

Re: [Nbd] [PATCH v3 2/2] doc: Add details on block sizes

Eric, (sic) >>> +During transmission phase, several operations are constrained by the >>> +export size sent in reply to `NBD_OPT_EXPORT_NAME` or `NBD_OPT_GO` >> >> or NBD_OPT_INFO? > > Not really - while NBD_OPT_INFO followed by NBD_OPT_GO _should_ send the > same export size, it is feasible tha

Re: [Nbd] More efficient treatment of experimental protocol extensions

Eric, On 14 Apr 2016, at 17:45, Eric Blake wrote: >>> I'll leave it until the patient is in recovery before doing that one. >>> >>> Structured replies is (famous last words) already in that state. > > Stable, but not out of observation yet (while I _have_ done scratch > implementations of INFO

Re: [Nbd] [PATCH v3 2/2] doc: Add details on block sizes

On Thu, Apr 14, 2016 at 05:52:06PM +0100, Alex Bligh wrote: > >> Could we not just use one of the client flags? We have 32 bits of > >> them (as opposed to 16 server flags). It's right at the start > >> of the negotiation, and we simply need to refer to whether > >> NBD_FLAG_C_BLOCKSIZE is set. It

[Nbd] [PATCHv2] Docs: improve description of disconnection methods

Improve the documentation as per the mailing list discussion. Here's what we decided (broadly). * One side MAY drop the connection if the other end violates a MUST condition. * The server MUST drop the connection in the 'no way out' situations during the negotiation phase (error on NBD_OPT_EXPO

[Nbd] [APPLIED by AMB] [PATCH] docs/proto.md: correct trivial formatting issues

Signed-off-by: Alex Bligh --- doc/proto.md | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/doc/proto.md b/doc/proto.md index f7d8c3c..d1c5749 100644 --- a/doc/proto.md +++ b/doc/proto.md @@ -204,18 +204,18 @@ required to. There is no requirement for the cli

[Nbd] [PATCH] doc: Fix a couple typos

Signed-off-by: Eric Blake --- I ran the document through ispell, and while ispell doesn't recognize acronyms like TLS, I didn't spot any other obvious problems. doc/proto.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/proto.md b/doc/proto.md index d1c5749..13b807

Re: [Nbd] [PATCH] doc: Fix a couple typos

Eric, Thanks. Applied. Alex On 14 Apr 2016, at 20:13, Eric Blake wrote: > Signed-off-by: Eric Blake > --- > > I ran the document through ispell, and while ispell doesn't > recognize acronyms like TLS, I didn't spot any other obvious > problems. > > doc/proto.md | 4 ++-- > 1 file changed, 2

Re: [Nbd] [PATCHv2] Docs: improve description of disconnection methods

On 04/14/2016 12:52 PM, Alex Bligh wrote: > Improve the documentation as per the mailing list discussion. > Here's what we decided (broadly). > > * The server SHOULD NOT otherwise drop the connection. It can wait > and error the next command. Clearly there are situations where > this is going t

Re: [Nbd] [PATCHv2] Docs: improve description of disconnection methods

Eric, (comments taken unless otherwise detailed). >> + >> +If either the client or the server detects a violation of a >> +mandatory condition ('MUST' etc.) by the other party, it MAY >> +initiate a hard disconnect. >> + >> +A client MAY use a soft disconnect to terminate the session >> +whenever

[Nbd] [PATCHv3] Docs: improve description of disconnection methods

Improve the documentation as per the mailing list discussion. Here's what we decided (broadly). * One side MAY drop the connection if the other end violates a MUST condition. * The server MUST drop the connection in the 'no way out' situations during the negotiation phase (error on NBD_OPT_EX

Re: [Nbd] [PATCHv3] Docs: improve description of disconnection methods

On 04/14/2016 02:12 PM, Alex Bligh wrote: > Improve the documentation as per the mailing list discussion. > Here's what we decided (broadly). > > * One side MAY drop the connection if the other end violates a > MUST condition. > > * The server MUST drop the connection in the 'no way out' situat

Re: [Nbd] [PATCHv3] Docs: improve description of disconnection methods

On 15 Apr 2016, at 00:04, Eric Blake wrote: > Looks okay to me, but I'd also wait for Wouter's review. Sure. He gave me commit rights, not maintainer rights :-) More seriously, this one was (in bits) controversial. > Reviewed-by: Eric Blake Thanks. -- Alex Bligh signature.asc Descrip

[Nbd] [PATCH v4 1/2] doc: Use sequence of replies for NBD_OPT_INFO/GO

Since NBD_OPT_INFO and NBD_OPT_GO are experimental, we still have a chance to fix them up before promoting them to stable. Attempting to reuse NBD_OPT_SERVER as the reply to NBD_OPT_INFO and NBD_OPT_GO has a few problems: clients must be prepared to parse two different styles of the reply, based o

[Nbd] [PATCH v4 0/2] block size extension

In v4: patch 1: Drop NBD_REP_EXPORT; a list of NBD_REP_INFO is sufficient Make it clear that NBD_REP_INFO followed by NBD_REP_ERR_* is okay Wording adjustments based on review patch 2: stronger focus on default minimum block size of 1 allow servers to accept clients even when NBD_OPT_BLOCK_SIZE n

[Nbd] [PATCH v4 2/2] doc: Add details on block sizes

Existing NBD servers often have limitations, such as requiring actions to be aligned to block sizes or limiting maximum transactions to avoid denial of service attacks; for example, qemu's NBD server refuses any transaction larger than 32M. But to date, clients have to learn these limitations via

[Nbd] KAARYAH- Summer Collection upto 50% off!

We hope you found this message to be useful. However, if you'd rather not receive future e-mails of this sort from Kaaryah.com, please opt-out here ( http://googleconnect.co.in/ga/unsubscribe/2-55979281-1454-3038-5837-438d7820919f27a-bd8fa2d5e6 ). Please note that this message was sent to the fo

[Nbd] Congratulations! Your Visa Card is here.

-- Find and fix application performance issues faster with Applications Manager

[Nbd] Dream Loans for your dream home

Hi, Find Best Home Loan Offers for you: Interest Rate from 9.85% Zero fees Up to 90% Financing Available Fastest Approval End-to-end Application Assistance Apply Now

[Nbd] These revelations will convert you into a rich person

[Nbd] BOOK Your DREAM Villa For just 7 LAKHS Pay REST on POSSESSION*.

-- Find and fix application performance issues faster with Applications Man

Re: [Nbd] [PATCHv2] Docs: improve description of disconnection methods

Hi Alex, On Thu, Apr 14, 2016 at 07:52:08PM +0100, Alex Bligh wrote: > +* `NBD_REP_ERR_SHUTDOWN` (2^32 + 7) > + > +The server is unwilling to continue negotiation as it has been > +shut down. is shutting down? ('has been' is past tense, at which point it cannot send anything anymore) [.

Re: [Nbd] [PATCHv3] Docs: improve description of disconnection methods

On Thu, Apr 14, 2016 at 05:04:57PM -0600, Eric Blake wrote: > On 04/14/2016 02:12 PM, Alex Bligh wrote: > > Improve the documentation as per the mailing list discussion. > > Here's what we decided (broadly). > > > > * One side MAY drop the connection if the other end violates a > > MUST conditio

Re: [Nbd] [PATCH v4 1/2] doc: Use sequence of replies for NBD_OPT_INFO/GO

Hi, On Thu, Apr 14, 2016 at 09:09:19PM -0600, Eric Blake wrote: [...] > The reply to an `NBD_OPT_GO` is identical to the reply to `NBD_OPT_INFO` > -save that if the reply indicates success (i.e. is `NBD_REP_SERVER`), > +save that if the reply indicates success (i.e. ends with `NBD_REP