Re: [Nbd] More efficient treatment of experimental protocol extensions

On 15 Apr 2016, at 14:25, Alex Bligh wrote: > > On 15 Apr 2016, at 14:18, Alex Bligh wrote: > >> Branch 'separate-extensions' is what would end up in master, >> and proto.md looks like this: >>

Re: [Nbd] [PATCH/RFC] Add support for NBD_CMD_WRITE_ZEROES

On 15 Apr 2016, at 15:10, Eric Blake wrote: > You completely ignore NBD_CMD_FLAG_NO_HOLE; you could obey that flag > (when set, do the calloc() here; when cleared, call into the trim code > if you can guarantee that you'll read zero after trims). Sadly you cannot guarantee

Re: [Nbd] [PATCH/RFC] Add support for NBD_CMD_WRITE_ZEROES

Eric, On 15 Apr 2016, at 15:10, Eric Blake wrote: > I posted qemu patches a while back, but they need a refresh. Those would be interesting. > You completely ignore NBD_CMD_FLAG_NO_HOLE; you could obey that flag > (when set, do the calloc() here; when cleared, call into the

Re: [Nbd] More efficient treatment of experimental protocol extensions

On 15 Apr 2016, at 14:18, Alex Bligh wrote: > Branch 'separate-extensions' is what would end up in master, > and proto.md looks like this: > https://github.com/abligh/nbd/blob/extension-write-zeroes/doc/proto.md Arrggh

Re: [Nbd] More efficient treatment of experimental protocol extensions

Wouter et al, On 14 Apr 2016, at 17:16, Alex Bligh wrote: > On 14 Apr 2016, at 16:38, Wouter Verhelst wrote: > >>> My proposal is as follows: >>> >>> * Experimental extensions do not appear in proto.md in master at all >>> EXCEPT for reservation of codes (e.g.

[Nbd] [PATCH/RFC] Add support for NBD_CMD_WRITE_ZEROES

This is a very basic implementation which could do with optimisation. Signed-off-by: Alex Bligh --- nbd-server.c | 74 nbd.h| 4 +++- 2 files changed, 73 insertions(+), 5 deletions(-) This is marked

Re: [Nbd] [PATCH v4 2/2] doc: Add details on block sizes

On 15 Apr 2016, at 08:09, Wouter Verhelst wrote: >> If a server advertises a minimum >> +block size, the advertised export size MUST be an integer multiple of >> +that block size. > > I think this can be a SHOULD without problem? Actually I think this should be a MUST. If the

Re: [Nbd] [PATCH v4 2/2] doc: Add details on block sizes

On 15 Apr 2016, at 04:09, Eric Blake wrote: > +## Block sizes > + > +During transmission phase, several operations are constrained by the > +export size sent by the final `NBD_OPT_EXPORT_NAME` or `NBD_OPT_GO`, > +as well as by three block sizes defined here (minimum,

Re: [Nbd] [PATCH v4 1/2] doc: Use sequence of replies for NBD_OPT_INFO/GO

Eric, > -Both options have identical formats for requests and replies. The > -only difference is that after a successful reply to `NBD_OPT_GO` > -(i.e. an `NBD_REP_SERVER`), transmission mode is entered immediately. > -Therefore these commands share common documentation. > +Both options have

[Nbd] Deals of the Day | Toolkit @Rs 129, 7W LED Bulb (Pack of 5) @Re 299, Wrench Set @Rs 249, Masks (Pack of 100) @Rs 225, Air Blower @Rs 493 and more.

Re: [Nbd] [PATCHv3] Docs: improve description of disconnection methods

On 15 Apr 2016, at 07:34, Wouter Verhelst wrote: >> >> Looks okay to me, but I'd also wait for Wouter's review. >> >> Reviewed-by: Eric Blake > > LGTM Applied (including the changes to ESHUTDOWN etc. tense usage that I said I'd made but had not committed

[Nbd] Stop Wishing To Lose Weight ,Take Action & Change Your Fate

Garcinia Cambogia, known as the Miracle Supplement is one of the safest and most effective ways to burn unwanted body fat. Garcinia Cambogia Extract is clinically

[Nbd] East Crest 2 & 3 BHK Premium Apartments on Old madras Road, Bangalore

-- Find and fix application performance issues faster with Applications Manager

Re: [Nbd] [PATCH v4 2/2] doc: Add details on block sizes

On Thu, Apr 14, 2016 at 09:09:20PM -0600, Eric Blake wrote: > Existing NBD servers often have limitations, such as requiring > actions to be aligned to block sizes or limiting maximum > transactions to avoid denial of service attacks; for example, > qemu's NBD server refuses any transaction larger

Re: [Nbd] [PATCH v4 1/2] doc: Use sequence of replies for NBD_OPT_INFO/GO

Hi, On Thu, Apr 14, 2016 at 09:09:19PM -0600, Eric Blake wrote: [...] > The reply to an `NBD_OPT_GO` is identical to the reply to `NBD_OPT_INFO` > -save that if the reply indicates success (i.e. is `NBD_REP_SERVER`), > +save that if the reply indicates success (i.e. ends with

Re: [Nbd] [PATCHv3] Docs: improve description of disconnection methods

On Thu, Apr 14, 2016 at 05:04:57PM -0600, Eric Blake wrote: > On 04/14/2016 02:12 PM, Alex Bligh wrote: > > Improve the documentation as per the mailing list discussion. > > Here's what we decided (broadly). > > > > * One side MAY drop the connection if the other end violates a > > MUST

[Nbd] BOOK Your DREAM Villa For just 7 LAKHS Pay REST on POSSESSION*.

-- Find and fix application performance issues faster with Applications Manager