Re: [Nbd] [PATCH v4 2/2] doc: Add details on block sizes

2016-04-15 Thread Alex Bligh
On 15 Apr 2016, at 08:09, Wouter Verhelst wrote: >> If a server advertises a minimum >> +block size, the advertised export size MUST be an integer multiple of >> +that block size. > > I think this can be a SHOULD without problem? Actually I think this should be a MUST. If the

Re: [Nbd] [PATCH v4 2/2] doc: Add details on block sizes

2016-04-15 Thread Alex Bligh
On 15 Apr 2016, at 04:09, Eric Blake wrote: > +## Block sizes > + > +During transmission phase, several operations are constrained by the > +export size sent by the final `NBD_OPT_EXPORT_NAME` or `NBD_OPT_GO`, > +as well as by three block sizes defined here (minimum,

Re: [Nbd] [PATCH v4 2/2] doc: Add details on block sizes

2016-04-15 Thread Wouter Verhelst
On Thu, Apr 14, 2016 at 09:09:20PM -0600, Eric Blake wrote: > Existing NBD servers often have limitations, such as requiring > actions to be aligned to block sizes or limiting maximum > transactions to avoid denial of service attacks; for example, > qemu's NBD server refuses any transaction larger

[Nbd] [PATCH v4 2/2] doc: Add details on block sizes

2016-04-14 Thread Eric Blake
Existing NBD servers often have limitations, such as requiring actions to be aligned to block sizes or limiting maximum transactions to avoid denial of service attacks; for example, qemu's NBD server refuses any transaction larger than 32M. But to date, clients have to learn these limitations via