Re: [Nbd] More efficient treatment of experimental protocol extensions

2016-04-17 Thread Alex Bligh
On 16 Apr 2016, at 18:30, Alex Bligh wrote: >>> >>> I'm interested in confirmation that this approach works for people. >> >> Sure does. > > Great. As you can see I've done the structured replies extension too > now. > >> Detail: might be an idea to retain the "extensions" section, but have

Re: [Nbd] More efficient treatment of experimental protocol extensions

2016-04-16 Thread Alex Bligh
Wouter, On 16 Apr 2016, at 18:06, Wouter Verhelst wrote: > Hi Alex, > > On Fri, Apr 15, 2016 at 02:18:37PM +0100, Alex Bligh wrote: >> I've moved out WRITE_ZEROES on my own github account (so >> we can all see what this looks like). > > Part of the reason I gave you push access was so you woul

Re: [Nbd] More efficient treatment of experimental protocol extensions

2016-04-16 Thread Wouter Verhelst
Hi Alex, On Fri, Apr 15, 2016 at 02:18:37PM +0100, Alex Bligh wrote: > I've moved out WRITE_ZEROES on my own github account (so > we can all see what this looks like). Part of the reason I gave you push access was so you wouldn't have to do that ;-) Just push it to my repo. Don't be too afraid t

Re: [Nbd] More efficient treatment of experimental protocol extensions

2016-04-15 Thread Alex Bligh
On 15 Apr 2016, at 14:25, Alex Bligh wrote: > > On 15 Apr 2016, at 14:18, Alex Bligh wrote: > >> Branch 'separate-extensions' is what would end up in master, >> and proto.md looks like this: >> https://github.com/abligh/nbd/blob/extension-write-zeroes/doc/proto.md > > Arrggh > > https://gi

Re: [Nbd] More efficient treatment of experimental protocol extensions

2016-04-15 Thread Alex Bligh
On 15 Apr 2016, at 14:18, Alex Bligh wrote: > Branch 'separate-extensions' is what would end up in master, > and proto.md looks like this: > https://github.com/abligh/nbd/blob/extension-write-zeroes/doc/proto.md Arrggh https://github.com/abligh/nbd/blob/separate-extensions/doc/proto.md --

Re: [Nbd] More efficient treatment of experimental protocol extensions

2016-04-15 Thread Alex Bligh
Wouter et al, On 14 Apr 2016, at 17:16, Alex Bligh wrote: > On 14 Apr 2016, at 16:38, Wouter Verhelst wrote: > >>> My proposal is as follows: >>> >>> * Experimental extensions do not appear in proto.md in master at all >>> EXCEPT for reservation of codes (e.g. "NBD_OPT_FOOBAR (42) - reserved

Re: [Nbd] More efficient treatment of experimental protocol extensions

2016-04-14 Thread Alex Bligh
Eric, On 14 Apr 2016, at 17:45, Eric Blake wrote: >>> I'll leave it until the patient is in recovery before doing that one. >>> >>> Structured replies is (famous last words) already in that state. > > Stable, but not out of observation yet (while I _have_ done scratch > implementations of INFO

Re: [Nbd] More efficient treatment of experimental protocol extensions

2016-04-14 Thread Eric Blake
On 04/14/2016 10:38 AM, Wouter Verhelst wrote: > On Thu, Apr 14, 2016 at 05:16:28PM +0100, Alex Bligh wrote: >> Wouter, >> >> On 14 Apr 2016, at 16:38, Wouter Verhelst wrote: >>> This sounds like a viable approach, >> >> I propose I come up with a patch to move the current experimental >> stuff ou

Re: [Nbd] More efficient treatment of experimental protocol extensions

2016-04-14 Thread Wouter Verhelst
On Thu, Apr 14, 2016 at 05:16:28PM +0100, Alex Bligh wrote: > Wouter, > > On 14 Apr 2016, at 16:38, Wouter Verhelst wrote: > > This sounds like a viable approach, > > I propose I come up with a patch to move the current experimental > stuff out to a branch then. > > As Erik currently is perform

Re: [Nbd] More efficient treatment of experimental protocol extensions

2016-04-14 Thread Alex Bligh
Wouter, On 14 Apr 2016, at 16:38, Wouter Verhelst wrote: >> My proposal is as follows: >> >> * Experimental extensions do not appear in proto.md in master at all >> EXCEPT for reservation of codes (e.g. "NBD_OPT_FOOBAR (42) - reserved >> for experimental FOOBAR extension"). >> >> * Experimen

Re: [Nbd] More efficient treatment of experimental protocol extensions

2016-04-14 Thread Wouter Verhelst
On Thu, Apr 14, 2016 at 01:46:35PM +0100, Alex Bligh wrote: > I have a proposal for the more efficient treatment of experimental > protocol extensions. This primarily concerns doc/proto.md, but > potentially affects code too. > > At present the experimental protocol extensions are described in > '

[Nbd] More efficient treatment of experimental protocol extensions

2016-04-14 Thread Alex Bligh
I have a proposal for the more efficient treatment of experimental protocol extensions. This primarily concerns doc/proto.md, but potentially affects code too. At present the experimental protocol extensions are described in 'experimental extensions' at the bottom of the document in master. This c