hg: jdk7/tl: 6936788: Minor adjustment to top repo test/Makefile, missing non-zero exit case

2010-03-19 Thread kelly . ohair
Changeset: 35d272ef7598 Author:ohair Date: 2010-03-19 18:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/35d272ef7598 6936788: Minor adjustment to top repo test/Makefile, missing non-zero exit case Reviewed-by: jjg ! test/Makefile

Re: Code Review 6706251: api/java_net/NetworkInterface/index.html#misc: getDisplayName() returned non null but empty String

2010-03-19 Thread Andrew John Hughes
On 19 March 2010 15:31, Michael McMahon wrote: > Christopher Hegarty - Sun Microsystems Ireland wrote: >> >> On 19/03/2010 15:04, Michael McMahon wrote: >>> >>> Christopher Hegarty - Sun Microsystems Ireland wrote: On 19/03/2010 14:42, Alan Bateman wrote: > > Christopher Hegarty

Re: Code Review 6706251: api/java_net/NetworkInterface/index.html#misc: getDisplayName() returned non null but empty String

2010-03-19 Thread Andrew John Hughes
On 19 March 2010 16:08, Michael McMahon wrote: > Looks good to me. > > - Michael. > > Christopher Hegarty - Sun Microsystems Ireland wrote: >> >> How about (thanks to Alan for the wording): >> >>      * A display name is a human readable String describing the network >>      * device. >>      * >>

Re: Code Review 6706251: api/java_net/NetworkInterface/index.html#misc: getDisplayName() returned non null but empty String

2010-03-19 Thread Michael McMahon
Looks good to me. - Michael. Christopher Hegarty - Sun Microsystems Ireland wrote: How about (thanks to Alan for the wording): * A display name is a human readable String describing the network * device. * - * @return the display name of this network interface, - *

Re: Code Review 6706251: api/java_net/NetworkInterface/index.html#misc: getDisplayName() returned non null but empty String

2010-03-19 Thread Christopher Hegarty - Sun Microsystems Ireland
How about (thanks to Alan for the wording): * A display name is a human readable String describing the network * device. * - * @return the display name of this network interface, - * or null if no display name is available. + * @return a non-empty string repr

Re: Code Review 6706251: api/java_net/NetworkInterface/index.html#misc: getDisplayName() returned non null but empty String

2010-03-19 Thread Andrew John Hughes
On 19 March 2010 15:12, Alan Bateman wrote: > Christopher Hegarty - Sun Microsystems Ireland wrote: >> >> : >> I vaguely remember the history of this issue (Michael will know better), >>  but the expectation from the API is that while empty string is not >> disallowed if the display name cannot be

Re: Code Review 6706251: api/java_net/NetworkInterface/index.html#misc: getDisplayName() returned non null but empty String

2010-03-19 Thread Michael McMahon
Christopher Hegarty - Sun Microsystems Ireland wrote: On 19/03/2010 15:04, Michael McMahon wrote: Christopher Hegarty - Sun Microsystems Ireland wrote: On 19/03/2010 14:42, Alan Bateman wrote: Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Michael, This is a forward port of a fix t

Re: Code Review 6706251: api/java_net/NetworkInterface/index.html#misc: getDisplayName() returned non null but empty String

2010-03-19 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: : I vaguely remember the history of this issue (Michael will know better), but the expectation from the API is that while empty string is not disallowed if the display name cannot be retrieved then null should be returned. I think such a

Re: Code Review 6706251: api/java_net/NetworkInterface/index.html#misc: getDisplayName() returned non null but empty String

2010-03-19 Thread Christopher Hegarty - Sun Microsystems Ireland
On 19/03/2010 15:04, Michael McMahon wrote: Christopher Hegarty - Sun Microsystems Ireland wrote: On 19/03/2010 14:42, Alan Bateman wrote: Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Michael, This is a forward port of a fix that you did in JDK6u11 to JDK7. The source changes are

Re: Code Review 6706251: api/java_net/NetworkInterface/index.html#misc: getDisplayName() returned non null but empty String

2010-03-19 Thread Michael McMahon
Christopher Hegarty - Sun Microsystems Ireland wrote: On 19/03/2010 14:42, Alan Bateman wrote: Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Michael, This is a forward port of a fix that you did in JDK6u11 to JDK7. The source changes are trivial and the very same as what went in 6.

Re: Code Review 6706251: api/java_net/NetworkInterface/index.html#misc: getDisplayName() returned non null but empty String

2010-03-19 Thread Christopher Hegarty - Sun Microsystems Ireland
On 19/03/2010 14:42, Alan Bateman wrote: Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Michael, This is a forward port of a fix that you did in JDK6u11 to JDK7. The source changes are trivial and the very same as what went in 6. The change is for strict conformance of getDisplayName

Re: Code Review 6706251: api/java_net/NetworkInterface/index.html#misc: getDisplayName() returned non null but empty String

2010-03-19 Thread Alan Bateman
Christopher Hegarty - Sun Microsystems Ireland wrote: Hi Michael, This is a forward port of a fix that you did in JDK6u11 to JDK7. The source changes are trivial and the very same as what went in 6. The change is for strict conformance of getDisplayName, should return null instead of an empt

Code Review 6632169: HttpClient and HttpsClient should not try to reverse lookup IP address of a proxy server

2010-03-19 Thread Christopher Hegarty - Sun Microsystems Ireland
Hi Michael, This is a forward port of a fix from JDK6u6 to JDK7. The source changes are small and the very same as what went in 6. The HttpClient was changed to use getHostString (does not perform reverse lookup), but the HttpsClient was overlooked at the time. This fix changes the HttpsClie

Code Review 6706251: api/java_net/NetworkInterface/index.html#misc: getDisplayName() returned non null but empty String

2010-03-19 Thread Christopher Hegarty - Sun Microsystems Ireland
Hi Michael, This is a forward port of a fix that you did in JDK6u11 to JDK7. The source changes are trivial and the very same as what went in 6. The change is for strict conformance of getDisplayName, should return null instead of an empty string. Webrev: http://cr.openjdk.java.net/~chega

hg: jdk7/tl/jdk: 6935233: java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java fails with modules build

2010-03-19 Thread christopher . hegarty
Changeset: 3bb93c410f41 Author:chegar Date: 2010-03-19 13:07 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3bb93c410f41 6935233: java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java fails with modules build Reviewed-by: alanb ! test/ProblemList.txt ! test/java/net/Serv