Re: Code Review Request: 7127771: (macosx)test/java/net/Socket/TrafficClass.java fails on Mac OS X

2012-01-16 Thread Alan Bateman
On 13/01/2012 21:02, Kurchi Hazra wrote: How does this look: http://cr.openjdk.java.net/~khazra/7127771/webrev.01/ - Kurchi This looks fine to me. -Alan

Re: Code Review Request: 7127771: (macosx)test/java/net/Socket/TrafficClass.java fails on Mac OS X

2012-01-16 Thread Michael McMahon
Yes, looks fine to me too. I would just update the comment above this code to add Mac OS to the Solaris case. Thanks Michael On 13/01/12 21:02, Kurchi Hazra wrote: How does this look: http://cr.openjdk.java.net/~khazra/7127771/webrev.01/ - Kurchi On 1/13/2012 12:14 PM, Alan Bateman wrote:

RFR 7129083: CookieManager does not store cookies if url is read before setting cookie manager

2012-01-16 Thread Chris Hegarty
The system-wide CookieHandler is read and stored in the sun.net.www.http(s) HttpClient/HttpsClient instance. Since this HttpClient/HttpsClient instance is cached and reused (where possible) as part of the persistent/keep-alive connection implementation, it will not reflect any changes made to t

Re: RFR 7129083: CookieManager does not store cookies if url is read before setting cookie manager

2012-01-16 Thread Michael McMahon
On 16/01/12 11:39, Chris Hegarty wrote: The system-wide CookieHandler is read and stored in the sun.net.www.http(s) HttpClient/HttpsClient instance. Since this HttpClient/HttpsClient instance is cached and reused (where possible) as part of the persistent/keep-alive connection implementation, i

hg: jdk8/tl/jdk: 7130398: ProblemList.txt updates (1/2012)

2012-01-16 Thread alan . bateman
Changeset: d1b0bda3a3c7 Author:alanb Date: 2012-01-16 16:30 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d1b0bda3a3c7 7130398: ProblemList.txt updates (1/2012) Reviewed-by: chegar ! test/ProblemList.txt

hg: jdk8/tl/jdk: 7129083: CookieManager does not store cookies if url is read before setting cookie manager

2012-01-16 Thread chris . hegarty
Changeset: e8a143213c65 Author:chegar Date: 2012-01-16 18:05 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8a143213c65 7129083: CookieManager does not store cookies if url is read before setting cookie manager Reviewed-by: michaelm ! src/share/classes/sun/net/www/http/Htt