Re: Code Review Request: 7144274: [macosx] Default IPv6 multicast interface is not being set when calling MulticastSocket.joinGroup()

2012-02-14 Thread Chris Hegarty
Trivially, I don't think getDefaultScopeID needs it's implementation to be ifdef'ed with MACOSX, at all. Then won't need the 'else return 0;'. It is just a general utility method to get the value of the defaultIndex field of NetworkInterace. Yes, the value will be 0 on all platforms other

hg: jdk8/tl/jdk: 7142888: sun/security/tools/jarsigner/ec.sh fail on sparc

2012-02-14 Thread vincent . x . ryan
Changeset: f62077973f9b Author:vinnie Date: 2012-02-14 11:47 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f62077973f9b 7142888: sun/security/tools/jarsigner/ec.sh fail on sparc Reviewed-by: xuelei ! test/sun/security/tools/jarsigner/ec.sh

Re: Code Review Request: 7144274: [macosx] Default IPv6 multicast interface is not being set when calling MulticastSocket.joinGroup()

2012-02-14 Thread Kurchi Hazra
Updated webrev: http://cr.openjdk.java.net/~khazra/7144274/webrev.02/ - Kurchi On 2/14/2012 12:58 AM, Chris Hegarty wrote: Trivially, I don't think getDefaultScopeID needs it's implementation to be ifdef'ed with MACOSX, at all. Then won't need the 'else return 0;'. It is just a general

Re: Code Review Request: 7144274: [macosx] Default IPv6 multicast interface is not being set when calling MulticastSocket.joinGroup()

2012-02-14 Thread Chris Hegarty
Looks fine to me. -Chris. On 02/14/12 07:12 PM, Kurchi Hazra wrote: Updated webrev: http://cr.openjdk.java.net/~khazra/7144274/webrev.02/ - Kurchi On 2/14/2012 12:58 AM, Chris Hegarty wrote: Trivially, I don't think getDefaultScopeID needs it's implementation to be ifdef'ed with MACOSX,

hg: jdk8/tl/langtools: 7142086: performance problem in Check.checkOverrideClashes(...)

2012-02-14 Thread maurizio . cimadamore
Changeset: 84b61130cbed Author:mcimadamore Date: 2012-02-14 15:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/84b61130cbed 7142086: performance problem in Check.checkOverrideClashes(...) Summary: Code in Check.checkOverrideClashes() causes too many calls to