Re: Code Review Request: 7045655: An empty InMemoryCookieStore should not return true for removeAll

2012-03-15 Thread Chris Hegarty
Thanks Kurchi, the change look good to me. This is a corner case and already covered by JCK, but it may be useful to amend an existing test to check for this. Maybe test/java/net/CookieHandler/NullUriCookieTest.java CookieStore cookieStore = (new CookieManager()).getCookieStore(); +

hg: jdk8/tl/jdk: 2 new changesets

2012-03-15 Thread michael . x . mcmahon
Changeset: ac5024504439 Author:michaelm Date: 2012-03-15 16:45 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac5024504439 7151898: Check for LANG in Mac OS X jdk build sanity check [macosx] Reviewed-by: ohair, smarks ! make/common/shared/Sanity.gmk Changeset: cfe2328912b3

Re: Code Review Request: 7045655: An empty InMemoryCookieStore should not return true for removeAll

2012-03-15 Thread Kurchi Hazra
Hi Chris, Updated webrev: http://cr.openjdk.java.net/~khazra/7045655/webrev.02/ - Kurchi On 3/15/2012 2:49 AM, Chris Hegarty wrote: Thanks Kurchi, the change look good to me. This is a corner case and already covered by JCK, but it may be useful to amend an existing test to check for th

Re: Code Review Request: 7045655: An empty InMemoryCookieStore should not return true for removeAll

2012-03-15 Thread Chris Hegarty
Thanks Kurchi, looks good. -Chris. Kurchi Hazra wrote: >Hi Chris, > > Updated webrev: http://cr.openjdk.java.net/~khazra/7045655/webrev.02/ > >- Kurchi > > >On 3/15/2012 2:49 AM, Chris Hegarty wrote: >> Thanks Kurchi, the change look good to me. >> >> This is a corner case and already cover

hg: jdk8/tl/jdk: 7045655: An empty InMemoryCookieStore should not return true for removeAll

2012-03-15 Thread kurchi . subhra . hazra
Changeset: 3bfebedb549f Author:khazra Date: 2012-03-15 13:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3bfebedb549f 7045655: An empty InMemoryCookieStore should not return true for removeAll Summary: CookieStore.removeAll() should return false for an empty CookieStore Re

hg: jdk8/tl/jdk: 2 new changesets

2012-03-15 Thread valerie . peng
Changeset: bdbc32b2f920 Author:valeriep Date: 2012-03-15 14:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bdbc32b2f920 7130959: Tweak 7058133 fix for JDK 8 (javah makefile changes) Summary: Fixed JAVAHFLAGS setting to use -bootclasspath. Reviewed-by: wetmore ! make/sun/s

hg: jdk8/tl/jdk: 7153343: Dependency on non-POSIX header file causes portability problem

2012-03-15 Thread littlee
Changeset: c4e66dc3222d Author:littlee Date: 2012-03-16 10:47 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c4e66dc3222d 7153343: Dependency on non-POSIX header file causes portability problem Summary: Remove the unneccessary link.h Reviewed-by: alanb, chegar Contributed-by