CR: 7183292: HttpURLConnection.getHeaderFields() throws IllegalArgumentException: Illegal cookie name

2012-07-17 Thread Michael McMahon
Hi, Could I get the following change reviewed please? http://cr.openjdk.java.net/~michaelm/7183292/webrev.1/ Since 7u4, we are parsing all incoming cookies via the HttpCookie class. This class has had a restriction on cookie names that is causing this problem and which is not required by any

Re: CR: 7183292: HttpURLConnection.getHeaderFields() throws IllegalArgumentException: Illegal cookie name

2012-07-17 Thread Chris Hegarty
On 17/07/2012 10:17, Michael McMahon wrote: Hi, Could I get the following change reviewed please? http://cr.openjdk.java.net/~michaelm/7183292/webrev.1/ Since 7u4, we are parsing all incoming cookies via the HttpCookie class. This class has had a restriction on cookie names that is causing

Re: CR: 7183292: HttpURLConnection.getHeaderFields() throws IllegalArgumentException: Illegal cookie name

2012-07-17 Thread Kurchi Subhra Hazra
I have read the sections dealing with cookie-name in 6265, and these changes look good to me. - Kurchi On 7/17/12 7:32 AM, Michael McMahon wrote: Thanks for reviewing this Chris. On the question of whether $ should be allowed in cookie names, it appears like that restriction has been

Re: CR: 7183292: HttpURLConnection.getHeaderFields() throws IllegalArgumentException: Illegal cookie name

2012-07-17 Thread Chris Hegarty
On 17/07/2012 15:32, Michael McMahon wrote: Thanks for reviewing this Chris. On the question of whether $ should be allowed in cookie names, it appears like that restriction has been removed from RFC 6265, which is evidently a fairly comprehensive description of actual cookie usage on the web.