hg: jdk8/tl/jdk: 6853676: OperatingSystemMXBean.TotalPhysicalMemorySize has incorrect value

2012-09-03 Thread staffan . larsen
Changeset: 3338019fda8a Author:sla Date: 2009-06-19 16:50 +0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3338019fda8a 6853676: OperatingSystemMXBean.TotalPhysicalMemorySize has incorrect value Reviewed-by: alanb, dholmes, sla Contributed-by: Dmytro Sheyko ! src/windows/nati

Re: Spec review of JEP 114: TLS Server Name Indication (SNI) Extension

2012-09-03 Thread Xuelei Fan
webrev: http://cr.openjdk.java.net/~xuelei/7068321/webrev_spec.10/ On 9/3/2012 9:22 PM, Chris Hegarty wrote: > Xuelei, > > This looks very good. Just a few minor comments: > > - SNIServerName hexes could be UPPERCASE, since it is a constant. > Yes. > - Trivially, SNIHostName(String) calls ID

Re: Spec review of JEP 114: TLS Server Name Indication (SNI) Extension

2012-09-03 Thread Chris Hegarty
Xuelei, This looks very good. Just a few minor comments: - SNIServerName hexes could be UPPERCASE, since it is a constant. - Trivially, SNIHostName(String) calls IDN.toASCII(hostname) twice It is not clear to me from this constructor whether it should pass a hostname "as understood by