On 8/12/13 1:45 PM, Xuelei Fan wrote:
new webrev: http://cr.openjdk.java.net/~xuelei/8020842/webrev.06/
Lines 280 and 333: How about we call them steps 8a and 8b?
Step 8 is referring to the steps in RFC 3490. Let's use "step 8".
You break the 1 <= len <= 63 check into two parts, that's w
new webrev: http://cr.openjdk.java.net/~xuelei/8020842/webrev.06/
> Lines 280 and 333: How about we call them steps 8a and 8b?
Step 8 is referring to the steps in RFC 3490. Let's use "step 8".
Thanks,
Xuelei
On 8/12/2013 11:11 AM, Weijun Wang wrote:
> I think the fix is adequate and necessary.
if (q < input.length()) { // Ah, a dot!
out.append('.');
}
p = q + 1;
Using
if (q != input.length())
should be even better. The searchDots method clearly specifies that "or
if there is no dots, return the length of input string".
--Max
I think the fix is adequate and necessary.
One problem: lines 367-373 adds a new IAE to ToUnicode but the method
should not fail forever.
And some small comments on styles etc.
On 8/12/13 9:09 AM, Xuelei Fan wrote:
new webrev: http://cr.openjdk.java.net/~xuelei/8020842/webrev.05/
Lines 123
Changeset: ea4f4164422e
Author:xuelei
Date: 2013-08-11 18:21 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ea4f4164422e
8022487: DEREncodedKeyValue.supportedKeyTypes should be private
Reviewed-by: mullan
!
src/share/classes/com/sun/org/apache/xml/internal/security/keys/con
new webrev: http://cr.openjdk.java.net/~xuelei/8020842/webrev.05/
Added a new test to test illegal hostname in SNIHostName.
Xuelei
On 8/10/2013 10:49 AM, Xuelei Fan wrote:
> Hi Michael,
>
> It is pretty hard to get the issue solved in SNIHostName in a good
> sharp. Here is my try to state why
